Commit 44023563 authored by Camillo Bruni's avatar Camillo Bruni Committed by V8 LUCI CQ

[flags] Remove unused FLAG_log_handles and related code

Change-Id: I97d29623e163ceee450814f03fba745d478082ff
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3574550
Auto-Submit: Camillo Bruni <cbruni@chromium.org>
Reviewed-by: 's avatarMarja Hölttä <marja@chromium.org>
Commit-Queue: Marja Hölttä <marja@chromium.org>
Cr-Commit-Position: refs/heads/main@{#79839}
parent 9ba6aff2
...@@ -2016,7 +2016,6 @@ DEFINE_BOOL(log_code, false, ...@@ -2016,7 +2016,6 @@ DEFINE_BOOL(log_code, false,
DEFINE_BOOL(log_code_disassemble, false, DEFINE_BOOL(log_code_disassemble, false,
"Log all disassembled code to the log file.") "Log all disassembled code to the log file.")
DEFINE_IMPLICATION(log_code_disassemble, log_code) DEFINE_IMPLICATION(log_code_disassemble, log_code)
DEFINE_BOOL(log_handles, false, "Log global handle events.")
DEFINE_BOOL(log_source_code, false, "Log source code.") DEFINE_BOOL(log_source_code, false, "Log source code.")
DEFINE_BOOL(log_function_events, false, DEFINE_BOOL(log_function_events, false,
"Log function events " "Log function events "
......
...@@ -138,7 +138,6 @@ void V8::Initialize() { ...@@ -138,7 +138,6 @@ void V8::Initialize() {
&FLAG_log_api, &FLAG_log_api,
&FLAG_log_code, &FLAG_log_code,
&FLAG_log_code_disassemble, &FLAG_log_code_disassemble,
&FLAG_log_handles,
&FLAG_log_source_code, &FLAG_log_source_code,
&FLAG_log_function_events, &FLAG_log_function_events,
&FLAG_log_internal_timer_events, &FLAG_log_internal_timer_events,
......
...@@ -1074,13 +1074,6 @@ void Logger::IntPtrTEvent(const char* name, intptr_t value) { ...@@ -1074,13 +1074,6 @@ void Logger::IntPtrTEvent(const char* name, intptr_t value) {
msg.WriteToLogFile(); msg.WriteToLogFile();
} }
void Logger::HandleEvent(const char* name, Address* location) {
if (!FLAG_log_handles) return;
MSG_BUILDER();
msg << name << kNext << reinterpret_cast<void*>(location);
msg.WriteToLogFile();
}
void Logger::WriteApiSecurityCheck() { void Logger::WriteApiSecurityCheck() {
DCHECK(FLAG_log_api); DCHECK(FLAG_log_api);
MSG_BUILDER(); MSG_BUILDER();
......
...@@ -141,9 +141,6 @@ class Logger : public CodeEventListener { ...@@ -141,9 +141,6 @@ class Logger : public CodeEventListener {
// Emits an event with an int value -> (name, value). // Emits an event with an int value -> (name, value).
void IntPtrTEvent(const char* name, intptr_t value); void IntPtrTEvent(const char* name, intptr_t value);
// Emits an event with an handle value -> (name, location).
void HandleEvent(const char* name, Address* location);
// Emits memory management events for C allocated structures. // Emits memory management events for C allocated structures.
void NewEvent(const char* name, void* object, size_t size); void NewEvent(const char* name, void* object, size_t size);
void DeleteEvent(const char* name, void* object); void DeleteEvent(const char* name, void* object);
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment