Commit 43d61196 authored by Clemens Backes's avatar Clemens Backes Committed by Commit Bot

[wasm] Remove unused parameter from Drop

Neither Liftoff nor the WasmGraphBuildingInterface use the parameter,
hence drop it.

R=jkummerow@chromium.org

Change-Id: Ia7f2b81dfc95f31c27e12d4ada07c5603a34abff
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2593335
Commit-Queue: Clemens Backes <clemensb@chromium.org>
Reviewed-by: 's avatarJakob Kummerow <jkummerow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#71784}
parent 56354ab3
......@@ -1722,7 +1722,7 @@ class LiftoffCompiler {
__ PushRegister(ValueType::Ref(arg.type.heap_type(), kNonNullable), obj);
}
void Drop(FullDecoder* decoder, const Value& value) {
void Drop(FullDecoder* decoder) {
auto& slot = __ cache_state()->stack_state.back();
// If the dropped slot contains a register, decrement it's use count.
if (slot.is_reg()) __ cache_state()->dec_used(slot.reg());
......@@ -4117,7 +4117,7 @@ class LiftoffCompiler {
__ bind(&cont_false);
// Drop the branch's value, restore original value.
Drop(decoder, obj);
Drop(decoder);
__ PushRegister(obj.type, obj_reg);
}
......
......@@ -993,7 +993,7 @@ struct ControlBase : public PcForErrors<validate> {
F(RefNull, ValueType type, Value* result) \
F(RefFunc, uint32_t function_index, Value* result) \
F(RefAsNonNull, const Value& arg, Value* result) \
F(Drop, const Value& value) \
F(Drop) \
F(DoReturn, Vector<Value> values) \
F(LocalGet, Value* result, const LocalIndexImmediate<validate>& imm) \
F(LocalSet, const Value& value, const LocalIndexImmediate<validate>& imm) \
......@@ -2953,8 +2953,8 @@ class WasmFullDecoder : public WasmDecoder<validate> {
}
DECODE(Drop) {
Value value = Pop(0);
CALL_INTERFACE_IF_REACHABLE(Drop, value);
Pop(0);
CALL_INTERFACE_IF_REACHABLE(Drop);
return 1;
}
......
......@@ -277,7 +277,7 @@ class WasmGraphBuildingInterface {
result->node = BUILD(RefAsNonNull, arg.node, decoder->position());
}
void Drop(FullDecoder* decoder, const Value& value) {}
void Drop(FullDecoder* decoder) {}
void DoReturn(FullDecoder* decoder, Vector<Value> values) {
base::SmallVector<TFNode*, 8> nodes(values.size());
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment