Commit 43a805fc authored by dcarney@chromium.org's avatar dcarney@chromium.org

added type checks on fast return values

R=svenpanne@chromium.org
BUG=

Review URL: https://codereview.chromium.org/16939003

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@15188 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
parent 6e5c8fe8
...@@ -5712,11 +5712,13 @@ void ReturnValue<T>::Set(const Handle<S> handle) { ...@@ -5712,11 +5712,13 @@ void ReturnValue<T>::Set(const Handle<S> handle) {
template<typename T> template<typename T>
void ReturnValue<T>::Set(double i) { void ReturnValue<T>::Set(double i) {
TYPE_CHECK(T, Number);
Set(Number::New(GetIsolate(), i)); Set(Number::New(GetIsolate(), i));
} }
template<typename T> template<typename T>
void ReturnValue<T>::Set(int32_t i) { void ReturnValue<T>::Set(int32_t i) {
TYPE_CHECK(T, Integer);
typedef internal::Internals I; typedef internal::Internals I;
if (V8_LIKELY(I::IsValidSmi(i))) { if (V8_LIKELY(I::IsValidSmi(i))) {
*value_ = I::IntToSmi(i); *value_ = I::IntToSmi(i);
...@@ -5727,6 +5729,7 @@ void ReturnValue<T>::Set(int32_t i) { ...@@ -5727,6 +5729,7 @@ void ReturnValue<T>::Set(int32_t i) {
template<typename T> template<typename T>
void ReturnValue<T>::Set(uint32_t i) { void ReturnValue<T>::Set(uint32_t i) {
TYPE_CHECK(T, Integer);
typedef internal::Internals I; typedef internal::Internals I;
// Can't simply use INT32_MAX here for whatever reason. // Can't simply use INT32_MAX here for whatever reason.
bool fits_into_int32_t = (i & (1 << 31)) == 0; bool fits_into_int32_t = (i & (1 << 31)) == 0;
...@@ -5739,6 +5742,7 @@ void ReturnValue<T>::Set(uint32_t i) { ...@@ -5739,6 +5742,7 @@ void ReturnValue<T>::Set(uint32_t i) {
template<typename T> template<typename T>
void ReturnValue<T>::Set(bool value) { void ReturnValue<T>::Set(bool value) {
TYPE_CHECK(T, Boolean);
typedef internal::Internals I; typedef internal::Internals I;
int root_index; int root_index;
if (value) { if (value) {
...@@ -5751,18 +5755,21 @@ void ReturnValue<T>::Set(bool value) { ...@@ -5751,18 +5755,21 @@ void ReturnValue<T>::Set(bool value) {
template<typename T> template<typename T>
void ReturnValue<T>::SetNull() { void ReturnValue<T>::SetNull() {
TYPE_CHECK(T, Primitive);
typedef internal::Internals I; typedef internal::Internals I;
*value_ = *I::GetRoot(GetIsolate(), I::kNullValueRootIndex); *value_ = *I::GetRoot(GetIsolate(), I::kNullValueRootIndex);
} }
template<typename T> template<typename T>
void ReturnValue<T>::SetUndefined() { void ReturnValue<T>::SetUndefined() {
TYPE_CHECK(T, Primitive);
typedef internal::Internals I; typedef internal::Internals I;
*value_ = *I::GetRoot(GetIsolate(), I::kUndefinedValueRootIndex); *value_ = *I::GetRoot(GetIsolate(), I::kUndefinedValueRootIndex);
} }
template<typename T> template<typename T>
void ReturnValue<T>::SetEmptyString() { void ReturnValue<T>::SetEmptyString() {
TYPE_CHECK(T, String);
typedef internal::Internals I; typedef internal::Internals I;
*value_ = *I::GetRoot(GetIsolate(), I::kEmptyStringRootIndex); *value_ = *I::GetRoot(GetIsolate(), I::kEmptyStringRootIndex);
} }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment