Commit 43791ce0 authored by kozyatinskiy's avatar kozyatinskiy Committed by Commit bot

[inspector] finally removed *ExecuteScript from inspector

We don't need hints from embedder any more.

BUG=none
R=dgozman@chromium.org

Review-Url: https://codereview.chromium.org/2773143002
Cr-Commit-Position: refs/heads/master@{#44158}
parent 6235899f
...@@ -224,8 +224,6 @@ class V8_EXPORT V8Inspector { ...@@ -224,8 +224,6 @@ class V8_EXPORT V8Inspector {
virtual void resetContextGroup(int contextGroupId) = 0; virtual void resetContextGroup(int contextGroupId) = 0;
// Various instrumentation. // Various instrumentation.
virtual void willExecuteScript(v8::Local<v8::Context>, int scriptId) = 0;
virtual void didExecuteScript(v8::Local<v8::Context>) = 0;
virtual void idleStarted() = 0; virtual void idleStarted() = 0;
virtual void idleFinished() = 0; virtual void idleFinished() = 0;
......
...@@ -239,13 +239,6 @@ void V8InspectorImpl::resetContextGroup(int contextGroupId) { ...@@ -239,13 +239,6 @@ void V8InspectorImpl::resetContextGroup(int contextGroupId) {
m_debugger->wasmTranslation()->Clear(); m_debugger->wasmTranslation()->Clear();
} }
void V8InspectorImpl::willExecuteScript(v8::Local<v8::Context> context,
int scriptId) {
}
void V8InspectorImpl::didExecuteScript(v8::Local<v8::Context> context) {
}
void V8InspectorImpl::idleStarted() { void V8InspectorImpl::idleStarted() {
for (auto it = m_sessions.begin(); it != m_sessions.end(); ++it) { for (auto it = m_sessions.begin(); it != m_sessions.end(); ++it) {
if (it->second->profilerAgent()->idleStarted()) return; if (it->second->profilerAgent()->idleStarted()) return;
......
...@@ -74,8 +74,6 @@ class V8InspectorImpl : public V8Inspector { ...@@ -74,8 +74,6 @@ class V8InspectorImpl : public V8Inspector {
void contextCreated(const V8ContextInfo&) override; void contextCreated(const V8ContextInfo&) override;
void contextDestroyed(v8::Local<v8::Context>) override; void contextDestroyed(v8::Local<v8::Context>) override;
void resetContextGroup(int contextGroupId) override; void resetContextGroup(int contextGroupId) override;
void willExecuteScript(v8::Local<v8::Context>, int scriptId) override;
void didExecuteScript(v8::Local<v8::Context>) override;
void idleStarted() override; void idleStarted() override;
void idleFinished() override; void idleFinished() override;
unsigned exceptionThrown(v8::Local<v8::Context>, const StringView& message, unsigned exceptionThrown(v8::Local<v8::Context>, const StringView& message,
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment