[diagnostics] Fix macos system instrumentation for ios-sim

Original CL: https://chromium-review.googlesource.com/c/v8/v8/+/2807157

Bug: v8:11043
Change-Id: I49d29323bf3ae6ede7e48e63645f4ee0a750c83e
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2818573Reviewed-by: Camillo Bruni <cbruni@chromium.org>
Commit-Queue: Sara Tang <sartang@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#73931}

BUILD.gn

@@ -4798,7 +4798,7 @@ v8_component("v8_libplatform") {
   } else if (is_win) {
     sources -= [ "src/libplatform/tracing/recorder-default.cc" ]
     sources += [ "src/libplatform/tracing/recorder-win.cc" ]
-  } else if (is_mac) {
+  } else if (target_os == "mac") {
     sources -= [ "src/libplatform/tracing/recorder-default.cc" ]
     sources += [ "src/libplatform/tracing/recorder-mac.cc" ]
   }

src/d8/d8.cc

@@ -4070,11 +4070,11 @@ bool Shell::SetOptions(int argc, char* argv[]) {
       options.fuzzy_module_file_extensions = true;
       argv[i] = nullptr;
 #if defined(V8_ENABLE_SYSTEM_INSTRUMENTATION)
-#if defined(V8_OS_WIN) || defined(V8_OS_MACOSX)
+#if defined(V8_TARGET_OS_WIN) || defined(V8_TARGET_OS_MACOSX)
     } else if (strcmp(argv[i], "--enable-system-instrumentation") == 0) {
       options.enable_system_instrumentation = true;
       options.trace_enabled = true;
-#if defined(V8_OS_WIN)
+#if defined(V8_TARGET_OS_WIN)
       // Guard this bc the flag has a lot of overhead and is not currently used
       // by macos
       i::FLAG_interpreted_frames_native_stack = true;