[cpu-profiler] Remove extra logging

We found the nexus 5x flake so this is no longer needed.

Leave the printing functions themselves as they will still be useful
for local debugging.

Bug: v8:8649
Change-Id: Ie0af2bc9b0fc7fb8ac00ec0039b6898553865189
Reviewed-on: https://chromium-review.googlesource.com/c/1420957Reviewed-by: Yang Guo <yangguo@chromium.org>
Commit-Queue: Peter Marshall <petermarshall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#58923}

src/flag-definitions.h

@@ -930,8 +930,6 @@ DEFINE_BOOL(trace_compiler_dispatcher, false,
 // cpu-profiler.cc
 DEFINE_INT(cpu_profiler_sampling_interval, 1000,
            "CPU profiler sampling interval in microseconds")
-DEFINE_BOOL(cpu_profiler_logging, false,
-            "Detailed logging from the CPU profiler to help find bugs")
 
 // Array abuse tracing
 DEFINE_BOOL(trace_js_array_abuse, false,

src/profiler/profile-generator.cc

@@ -780,11 +780,6 @@ void ProfileGenerator::RecordTickSample(const TickSample& sample) {
   int src_line = no_line_info;
   bool src_line_not_found = true;
 
-  if (FLAG_cpu_profiler_logging) {
-    PrintF("RecordTickSample: ");
-    sample.print();
-  }
-
   if (sample.pc != nullptr) {
     if (sample.has_external_callback && sample.state == EXTERNAL) {
       // Don't use PC when in external callback code, as it can point
@@ -895,18 +890,6 @@ void ProfileGenerator::RecordTickSample(const TickSample& sample) {
     }
   }
 
-  if (FLAG_cpu_profiler_logging) {
-    PrintF("stack_trace:\n");
-    for (const CodeEntryAndLineNumber& pair : stack_trace) {
-      if (pair.code_entry) {
-        PrintF("  %s at %d\n", pair.code_entry->name(), pair.line_number);
-      } else {
-        PrintF("  null code entry\n");
-      }
-    }
-    PrintF("\n");
-  }
-
   profiles_->AddPathToCurrentProfiles(sample.timestamp, stack_trace, src_line,
                                       sample.update_stats);
 }

src/profiler/profiler-listener.cc

@@ -177,11 +177,6 @@ void ProfilerListener::CodeCreateEvent(CodeEventListener::LogEventsAndTags tag,
   }
 
   rec->entry->FillFunctionInfo(shared);
-
-  if (FLAG_cpu_profiler_logging) {
-    PrintF("CodeCreateEvent: ");
-    rec->entry->print();
-  }
   rec->instruction_size = abstract_code->InstructionSize();
   DispatchCodeEvent(evt_rec);
 }

test/cctest/cctest.cc

@@ -95,7 +95,6 @@ void CcTest::Run() {
     }
     isolate_->Enter();
   }
-  i::FLAG_cpu_profiler_logging = true;
 #ifdef DEBUG
   const size_t active_isolates = i::Isolate::non_disposed_isolates();
 #endif  // DEBUG