Commit 41686619 authored by Andreas Haas's avatar Andreas Haas Committed by V8 LUCI CQ

[wasm] Reenable externref globals inspector test

The test was a bit out-dated, the expected file did not match the test
or the data delivered by V8 anymore. However, all the expected data was
available, so I just adjusted the test accordingly.

R=clemensb@chromium.org

Bug: v8:10356
Change-Id: I1d94f2a295038a4320e07706d46258a278a6dee5
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2968410Reviewed-by: 's avatarClemens Backes <clemensb@chromium.org>
Commit-Queue: Andreas Haas <ahaas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#75222}
parent cb0b7eed
Test wasm scope information with externref globals Test wasm scope information with externref globals
Running test: test
Waiting for wasm script to be parsed. Waiting for wasm script to be parsed.
Setting breakpoint in wasm. Setting breakpoint in wasm.
Running main. Running main.
Paused in debugger. Paused in debugger.
globals: {"m.global": hello, world} globals: {"name": $m.global, "type": externref, "value": hello, world}
Finished.
...@@ -67,11 +67,14 @@ InspectorTest.runAsyncTestSuite([ ...@@ -67,11 +67,14 @@ InspectorTest.runAsyncTestSuite([
if (prop.name != 'globals') continue; if (prop.name != 'globals') continue;
let subProps = (await Protocol.Runtime.getProperties({ let subProps = (await Protocol.Runtime.getProperties({
objectId: prop.value.objectId objectId: prop.value.objectId
})).result.result[0];
let subsubProps = (await Protocol.Runtime.getProperties({
objectId: subProps.value.objectId
})).result.result; })).result.result;
let values = let values =
subProps.map((value) => `"${value.name}": ${value.value.value}`) subsubProps.map((value) => `"${value.name}": ${value.value.value}`)
.join(', '); .join(', ');
InspectorTest.log(` ${prop.name}: {${values}}`); InspectorTest.log(` ${prop.name}: {"name": ${subProps.name}, ${values}}`);
} }
} }
} }
......
...@@ -15,11 +15,6 @@ ...@@ -15,11 +15,6 @@
# https://crbug.com/v8/9029 # https://crbug.com/v8/9029
'debugger/script-on-after-compile-snapshot': [SKIP], 'debugger/script-on-after-compile-snapshot': [SKIP],
# https://crbug.com/v8/10356
# This test worked in the wasm interpreter, but fails when using Liftoff for
# debugging.
'debugger/wasm-externref-global': [FAIL],
# https://crbug.com/1080638 # https://crbug.com/1080638
# The initial CL only fixed the crash. The test still causes an endless # The initial CL only fixed the crash. The test still causes an endless
# loop instead of properly reporting a RangeError for a stack overflow. # loop instead of properly reporting a RangeError for a stack overflow.
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment