Commit 4064c41e authored by petermarshall's avatar petermarshall Committed by Commit bot

[MIPS64] Fix tagged vs. untagged SMI comparison in Apply builtin.

This fast path check compared a tagged smi and an untagged one, meaning that the slow path was always taken.

Review-Url: https://codereview.chromium.org/2641823002
Cr-Commit-Position: refs/heads/master@{#42445}
parent 0b8200c7
......@@ -2198,7 +2198,7 @@ void Builtins::Generate_Apply(MacroAssembler* masm) {
Context::INITIAL_ARRAY_PROTOTYPE_INDEX));
__ Branch(&create_runtime, ne, a2, Operand(at));
__ LoadRoot(at, Heap::kArrayProtectorRootIndex);
__ lw(a2, UntagSmiFieldMemOperand(at, PropertyCell::kValueOffset));
__ lw(a2, FieldMemOperand(at, PropertyCell::kValueOffset));
__ Branch(&create_runtime, ne, a2,
Operand(Smi::FromInt(Isolate::kProtectorValid)));
__ lw(a2, UntagSmiFieldMemOperand(a0, JSArray::kLengthOffset));
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment