Remove obsolete Oddball setters in FixedArray.

R=bmeurer@chromium.org

Review URL: https://codereview.chromium.org/23705002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16404 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
parent 57ac971a
...@@ -3414,7 +3414,7 @@ void Heap::FlushNumberStringCache() { ...@@ -3414,7 +3414,7 @@ void Heap::FlushNumberStringCache() {
// Flush the number to string cache. // Flush the number to string cache.
int len = number_string_cache()->length(); int len = number_string_cache()->length();
for (int i = 0; i < len; i++) { for (int i = 0; i < len; i++) {
number_string_cache()->set_undefined(this, i); number_string_cache()->set_undefined(i);
} }
} }
......
...@@ -2590,7 +2590,7 @@ void MarkCompactCollector::ClearNonLivePrototypeTransitions(Map* map) { ...@@ -2590,7 +2590,7 @@ void MarkCompactCollector::ClearNonLivePrototypeTransitions(Map* map) {
for (int i = new_number_of_transitions * step; for (int i = new_number_of_transitions * step;
i < number_of_transitions * step; i < number_of_transitions * step;
i++) { i++) {
prototype_transitions->set_undefined(heap_, header + i); prototype_transitions->set_undefined(header + i);
} }
} }
......
...@@ -2092,28 +2092,21 @@ void FixedArray::NoWriteBarrierSet(FixedArray* array, ...@@ -2092,28 +2092,21 @@ void FixedArray::NoWriteBarrierSet(FixedArray* array,
void FixedArray::set_undefined(int index) { void FixedArray::set_undefined(int index) {
ASSERT(map() != HEAP->fixed_cow_array_map()); ASSERT(map() != GetHeap()->fixed_cow_array_map());
set_undefined(GetHeap(), index);
}
void FixedArray::set_undefined(Heap* heap, int index) {
ASSERT(index >= 0 && index < this->length()); ASSERT(index >= 0 && index < this->length());
ASSERT(!heap->InNewSpace(heap->undefined_value())); ASSERT(!GetHeap()->InNewSpace(GetHeap()->undefined_value()));
WRITE_FIELD(this, kHeaderSize + index * kPointerSize, WRITE_FIELD(this,
heap->undefined_value()); kHeaderSize + index * kPointerSize,
GetHeap()->undefined_value());
} }
void FixedArray::set_null(int index) { void FixedArray::set_null(int index) {
set_null(GetHeap(), index);
}
void FixedArray::set_null(Heap* heap, int index) {
ASSERT(index >= 0 && index < this->length()); ASSERT(index >= 0 && index < this->length());
ASSERT(!heap->InNewSpace(heap->null_value())); ASSERT(!GetHeap()->InNewSpace(GetHeap()->null_value()));
WRITE_FIELD(this, kHeaderSize + index * kPointerSize, heap->null_value()); WRITE_FIELD(this,
kHeaderSize + index * kPointerSize,
GetHeap()->null_value());
} }
......
...@@ -2913,11 +2913,7 @@ class FixedArray: public FixedArrayBase { ...@@ -2913,11 +2913,7 @@ class FixedArray: public FixedArrayBase {
// Setters for frequently used oddballs located in old space. // Setters for frequently used oddballs located in old space.
inline void set_undefined(int index); inline void set_undefined(int index);
// TODO(isolates): duplicate.
inline void set_undefined(Heap* heap, int index);
inline void set_null(int index); inline void set_null(int index);
// TODO(isolates): duplicate.
inline void set_null(Heap* heap, int index);
inline void set_the_hole(int index); inline void set_the_hole(int index);
inline Object** GetFirstElementAddress(); inline Object** GetFirstElementAddress();
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment