Commit 3f0cc043 authored by feng@chromium.org's avatar feng@chromium.org

Turn ASSERT(!rn.is(ip)) into CHECK so the error can be caught in release mode.

It addresses the problem of 'cmp' instruction that has the side-effect that ip register
shouldn't be used as rn.

Review URL: http://codereview.chromium.org/11323

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@810 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
parent 1e751779
......@@ -554,7 +554,7 @@ void Assembler::addrmod1(Instr instr,
// However, if the original instruction is a 'mov rd, x' (not setting the
// condition code), then replace it with a 'ldr rd, [pc]'
RecordRelocInfo(x.rmode_, x.imm32_);
ASSERT(!rn.is(ip)); // rn should never be ip, or will be trashed
CHECK(!rn.is(ip)); // rn should never be ip, or will be trashed
Condition cond = static_cast<Condition>(instr & CondMask);
if ((instr & ~CondMask) == 13*B21) { // mov, S not set
ldr(rd, MemOperand(pc, 0), cond);
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment