Commit 3ee4ead5 authored by Georg Neis's avatar Georg Neis Committed by Commit Bot

Revert "[turbofan] Refine a DCHECK"

This reverts commit a596efcc.

Reason for revert: Was incorrect. Holes can appear in dead code.

Original change's description:
> [turbofan] Refine a DCHECK
>
> Hole checks are done using a lower level comparison.
>
> Change-Id: I61c5b787f12564ad3553d395a36938a00f5dd554
> Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2172418
> Auto-Submit: Georg Neis <neis@chromium.org>
> Commit-Queue: Nico Hartmann <nicohartmann@chromium.org>
> Reviewed-by: Nico Hartmann <nicohartmann@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#67466}

TBR=neis@chromium.org,nicohartmann@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Change-Id: I47aff68cf8e224882a3eeac0d9edfe5a6228f0f2
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2181324
Commit-Queue: Georg Neis <neis@chromium.org>
Reviewed-by: 's avatarGeorg Neis <neis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#67561}
parent cc49f4fe
......@@ -1249,7 +1249,7 @@ Type OperationTyper::StrictEqual(Type lhs, Type rhs) {
// Types are equal and are inhabited only by a single semantic value,
// which is not nan due to the earlier check.
DCHECK(lhs.Is(rhs));
DCHECK(lhs.Is(Type::NonInternal()));
DCHECK(lhs.Is(Type::NonInternal()) || lhs.Is(Type::Hole()));
return singleton_true();
}
if ((lhs.Is(Type::Unique()) || rhs.Is(Type::Unique())) && !lhs.Maybe(rhs)) {
......
......@@ -1083,7 +1083,6 @@ Type Typer::Visitor::JSEqualTyper(Type lhs, Type rhs, Typer* t) {
// Types are equal and are inhabited only by a single semantic value,
// which is not nan due to the earlier check.
DCHECK(lhs.Is(rhs));
DCHECK(lhs.Is(Type::NonInternal()));
return t->singleton_true_;
}
return Type::Boolean();
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment