Commit 3d617c16 authored by mvstanton's avatar mvstanton Committed by Commit bot

[Turbofan] Remove more Type representation dimension data.

Happily, we can/should include semantic information such as Internal(), NonInternal() even as we remove representation data.

BUG=

Review-Url: https://codereview.chromium.org/2305573003
Cr-Commit-Position: refs/heads/master@{#39123}
parent 7c401bd8
...@@ -68,7 +68,7 @@ FieldAccess AccessBuilder::ForJSObjectInObjectProperty(Handle<Map> map, ...@@ -68,7 +68,7 @@ FieldAccess AccessBuilder::ForJSObjectInObjectProperty(Handle<Map> map,
FieldAccess access = {kTaggedBase, FieldAccess access = {kTaggedBase,
offset, offset,
MaybeHandle<Name>(), MaybeHandle<Name>(),
Type::Tagged(), Type::NonInternal(),
MachineType::AnyTagged(), MachineType::AnyTagged(),
kFullWriteBarrier}; kFullWriteBarrier};
return access; return access;
...@@ -116,12 +116,9 @@ FieldAccess AccessBuilder::ForJSFunctionLiterals() { ...@@ -116,12 +116,9 @@ FieldAccess AccessBuilder::ForJSFunctionLiterals() {
// static // static
FieldAccess AccessBuilder::ForJSFunctionCodeEntry() { FieldAccess AccessBuilder::ForJSFunctionCodeEntry() {
FieldAccess access = {kTaggedBase, FieldAccess access = {
JSFunction::kCodeEntryOffset, kTaggedBase, JSFunction::kCodeEntryOffset, Handle<Name>(),
Handle<Name>(), Type::OtherInternal(), MachineType::Pointer(), kNoWriteBarrier};
Type::UntaggedPointer(),
MachineType::Pointer(),
kNoWriteBarrier};
return access; return access;
} }
...@@ -218,7 +215,7 @@ FieldAccess AccessBuilder::ForJSArrayBufferBackingStore() { ...@@ -218,7 +215,7 @@ FieldAccess AccessBuilder::ForJSArrayBufferBackingStore() {
FieldAccess access = {kTaggedBase, FieldAccess access = {kTaggedBase,
JSArrayBuffer::kBackingStoreOffset, JSArrayBuffer::kBackingStoreOffset,
MaybeHandle<Name>(), MaybeHandle<Name>(),
Type::UntaggedPointer(), Type::OtherInternal(),
MachineType::Pointer(), MachineType::Pointer(),
kNoWriteBarrier}; kNoWriteBarrier};
return access; return access;
...@@ -237,7 +234,7 @@ FieldAccess AccessBuilder::ForJSArrayBufferViewBuffer() { ...@@ -237,7 +234,7 @@ FieldAccess AccessBuilder::ForJSArrayBufferViewBuffer() {
FieldAccess access = {kTaggedBase, FieldAccess access = {kTaggedBase,
JSArrayBufferView::kBufferOffset, JSArrayBufferView::kBufferOffset,
MaybeHandle<Name>(), MaybeHandle<Name>(),
Type::TaggedPointer(), Type::OtherInternal(),
MachineType::TaggedPointer(), MachineType::TaggedPointer(),
kPointerWriteBarrier}; kPointerWriteBarrier};
return access; return access;
...@@ -321,7 +318,7 @@ FieldAccess AccessBuilder::ForJSIteratorResultValue() { ...@@ -321,7 +318,7 @@ FieldAccess AccessBuilder::ForJSIteratorResultValue() {
FieldAccess AccessBuilder::ForJSRegExpFlags() { FieldAccess AccessBuilder::ForJSRegExpFlags() {
FieldAccess access = { FieldAccess access = {
kTaggedBase, JSRegExp::kFlagsOffset, MaybeHandle<Name>(), kTaggedBase, JSRegExp::kFlagsOffset, MaybeHandle<Name>(),
Type::Tagged(), MachineType::AnyTagged(), kFullWriteBarrier}; Type::NonInternal(), MachineType::AnyTagged(), kFullWriteBarrier};
return access; return access;
} }
...@@ -330,7 +327,7 @@ FieldAccess AccessBuilder::ForJSRegExpFlags() { ...@@ -330,7 +327,7 @@ FieldAccess AccessBuilder::ForJSRegExpFlags() {
FieldAccess AccessBuilder::ForJSRegExpSource() { FieldAccess AccessBuilder::ForJSRegExpSource() {
FieldAccess access = { FieldAccess access = {
kTaggedBase, JSRegExp::kSourceOffset, MaybeHandle<Name>(), kTaggedBase, JSRegExp::kSourceOffset, MaybeHandle<Name>(),
Type::Tagged(), MachineType::AnyTagged(), kFullWriteBarrier}; Type::NonInternal(), MachineType::AnyTagged(), kFullWriteBarrier};
return access; return access;
} }
...@@ -351,7 +348,7 @@ FieldAccess AccessBuilder::ForFixedTypedArrayBaseBasePointer() { ...@@ -351,7 +348,7 @@ FieldAccess AccessBuilder::ForFixedTypedArrayBaseBasePointer() {
FieldAccess access = {kTaggedBase, FieldAccess access = {kTaggedBase,
FixedTypedArrayBase::kBasePointerOffset, FixedTypedArrayBase::kBasePointerOffset,
MaybeHandle<Name>(), MaybeHandle<Name>(),
Type::Tagged(), Type::OtherInternal(),
MachineType::AnyTagged(), MachineType::AnyTagged(),
kPointerWriteBarrier}; kPointerWriteBarrier};
return access; return access;
...@@ -362,7 +359,7 @@ FieldAccess AccessBuilder::ForFixedTypedArrayBaseExternalPointer() { ...@@ -362,7 +359,7 @@ FieldAccess AccessBuilder::ForFixedTypedArrayBaseExternalPointer() {
FieldAccess access = {kTaggedBase, FieldAccess access = {kTaggedBase,
FixedTypedArrayBase::kExternalPointerOffset, FixedTypedArrayBase::kExternalPointerOffset,
MaybeHandle<Name>(), MaybeHandle<Name>(),
Type::UntaggedPointer(), Type::OtherInternal(),
MachineType::Pointer(), MachineType::Pointer(),
kNoWriteBarrier}; kNoWriteBarrier};
return access; return access;
...@@ -373,7 +370,7 @@ FieldAccess AccessBuilder::ForDescriptorArrayEnumCache() { ...@@ -373,7 +370,7 @@ FieldAccess AccessBuilder::ForDescriptorArrayEnumCache() {
FieldAccess access = {kTaggedBase, FieldAccess access = {kTaggedBase,
DescriptorArray::kEnumCacheOffset, DescriptorArray::kEnumCacheOffset,
Handle<Name>(), Handle<Name>(),
Type::TaggedPointer(), Type::OtherInternal(),
MachineType::TaggedPointer(), MachineType::TaggedPointer(),
kPointerWriteBarrier}; kPointerWriteBarrier};
return access; return access;
...@@ -385,7 +382,7 @@ FieldAccess AccessBuilder::ForDescriptorArrayEnumCacheBridgeCache() { ...@@ -385,7 +382,7 @@ FieldAccess AccessBuilder::ForDescriptorArrayEnumCacheBridgeCache() {
FieldAccess access = {kTaggedBase, FieldAccess access = {kTaggedBase,
DescriptorArray::kEnumCacheBridgeCacheOffset, DescriptorArray::kEnumCacheBridgeCacheOffset,
Handle<Name>(), Handle<Name>(),
Type::TaggedPointer(), Type::OtherInternal(),
MachineType::TaggedPointer(), MachineType::TaggedPointer(),
kPointerWriteBarrier}; kPointerWriteBarrier};
return access; return access;
...@@ -415,7 +412,7 @@ FieldAccess AccessBuilder::ForMapDescriptors() { ...@@ -415,7 +412,7 @@ FieldAccess AccessBuilder::ForMapDescriptors() {
FieldAccess access = {kTaggedBase, FieldAccess access = {kTaggedBase,
Map::kDescriptorsOffset, Map::kDescriptorsOffset,
Handle<Name>(), Handle<Name>(),
Type::TaggedPointer(), Type::OtherInternal(),
MachineType::TaggedPointer(), MachineType::TaggedPointer(),
kPointerWriteBarrier}; kPointerWriteBarrier};
return access; return access;
...@@ -433,12 +430,9 @@ FieldAccess AccessBuilder::ForMapInstanceType() { ...@@ -433,12 +430,9 @@ FieldAccess AccessBuilder::ForMapInstanceType() {
// static // static
FieldAccess AccessBuilder::ForMapPrototype() { FieldAccess AccessBuilder::ForMapPrototype() {
FieldAccess access = {kTaggedBase, FieldAccess access = {
Map::kPrototypeOffset, kTaggedBase, Map::kPrototypeOffset, Handle<Name>(),
Handle<Name>(), Type::Any(), MachineType::TaggedPointer(), kPointerWriteBarrier};
Type::TaggedPointer(),
MachineType::TaggedPointer(),
kPointerWriteBarrier};
return access; return access;
} }
...@@ -499,7 +493,7 @@ FieldAccess AccessBuilder::ForExternalStringResourceData() { ...@@ -499,7 +493,7 @@ FieldAccess AccessBuilder::ForExternalStringResourceData() {
FieldAccess access = {kTaggedBase, FieldAccess access = {kTaggedBase,
ExternalString::kResourceDataOffset, ExternalString::kResourceDataOffset,
Handle<Name>(), Handle<Name>(),
Type::UntaggedPointer(), Type::OtherInternal(),
MachineType::Pointer(), MachineType::Pointer(),
kNoWriteBarrier}; kNoWriteBarrier};
return access; return access;
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment