Commit 3d40bd94 authored by zhengxing.li's avatar zhengxing.li Committed by Commit bot

X87: Remove new.target value from construct stub frames.

  port eaa0e596 (r32550)

  original commit message:
  This drops the specific slot containing the new.target value from our
  construct stub frames. This side-channel has been deprecated and will
  no longer be accessed by any consumers.

BUG=

Review URL: https://codereview.chromium.org/1504703002

Cr-Commit-Position: refs/heads/master@{#32636}
parent e3b1cf17
...@@ -280,10 +280,6 @@ static void Generate_JSConstructStubHelper(MacroAssembler* masm, ...@@ -280,10 +280,6 @@ static void Generate_JSConstructStubHelper(MacroAssembler* masm,
__ SmiUntag(eax); __ SmiUntag(eax);
// Push new.target onto the construct frame. This is stored just below the
// receiver on the stack.
__ push(edx);
if (create_implicit_receiver) { if (create_implicit_receiver) {
// Push the allocated receiver to the stack. We need two copies // Push the allocated receiver to the stack. We need two copies
// because we may have to return the original one and the calling // because we may have to return the original one and the calling
...@@ -347,12 +343,11 @@ static void Generate_JSConstructStubHelper(MacroAssembler* masm, ...@@ -347,12 +343,11 @@ static void Generate_JSConstructStubHelper(MacroAssembler* masm,
__ mov(eax, Operand(esp, 0)); __ mov(eax, Operand(esp, 0));
// Restore the arguments count and leave the construct frame. The // Restore the arguments count and leave the construct frame. The
// arguments // arguments count is stored below the receiver.
// count is stored below the reciever and the new.target.
__ bind(&exit); __ bind(&exit);
__ mov(ebx, Operand(esp, 2 * kPointerSize)); __ mov(ebx, Operand(esp, 1 * kPointerSize));
} else { } else {
__ mov(ebx, Operand(esp, kPointerSize)); __ mov(ebx, Operand(esp, 0));
} }
// Leave construct frame. // Leave construct frame.
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment