Commit 3afb3324 authored by thakis's avatar thakis Committed by Commit bot

32-bit linux: Force 16-byte stack alignment.

clang assumes 16-byte stack alignment, but incoming stack alignment isn't
always guaranteed to be that way.  It looks like v8 was lucky to not hit
this so far.

See https://crbug.com/418554 -- this makes v8's standalone config match
Chromium.  See also https://llvm.org/bugs/show_bug.cgi?id=21414

Maybe it's possible to change the caller of OnEntryHook() to guarantee
the right alignment, but matching Chromium's build flags here seems like
a good idea in general.

BUG=v8:4928
LOG=n

Review URL: https://codereview.chromium.org/1899783002

Cr-Commit-Position: refs/heads/master@{#35597}
parent d412cfa2
......@@ -463,6 +463,9 @@
}],
],
}],
['clang==1 and target_arch=="ia32"', {
'cflags': ['-mstack-alignment=16', '-mstackrealign'],
}],
['fastbuild!=0', {
'conditions': [
['OS=="win" and fastbuild==1', {
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment