[cleanup] Move HashTable::IsKey from -inl.h into main header

It was perhaps incorrectly not declared inline while still appearing in
the main header file and then appearing in the -inl.h. MSVC doesn't like
it being declared inline however, so just inline it directly into the
main header.

Bug: v8:8510
Change-Id: I16106b91b3b4dff31e70382f2e66aa4f42fb290b
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1918249
Commit-Queue: Dan Elphick <delphick@chromium.org>
Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org>
Auto-Submit: Dan Elphick <delphick@chromium.org>
Reviewed-by: Santiago Aboy Solanes <solanes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#64988}

src/objects/hash-table-inl.h

@@ -160,11 +160,6 @@ InternalIndex HashTable<Derived, Shape>::FindEntry(ReadOnlyRoots roots, Key key,
   return InternalIndex::NotFound();
 }
 
-template <typename Derived, typename Shape>
-bool HashTable<Derived, Shape>::IsKey(ReadOnlyRoots roots, Object k) {
-  return Shape::IsKey(roots, k);
-}
-
 template <typename Derived, typename Shape>
 bool HashTable<Derived, Shape>::ToKey(ReadOnlyRoots roots, InternalIndex entry,
                                       Object* out_k) {

src/objects/hash-table.h

@@ -145,9 +145,11 @@ class EXPORT_TEMPLATE_DECLARE(V8_EXPORT_PRIVATE) HashTable
   // Rehashes the table in-place.
   void Rehash(ReadOnlyRoots roots);
 
-  // Tells whether k is a real key.  The hole and undefined are not allowed
-  // as keys and can be used to indicate missing or deleted elements.
-  static bool IsKey(ReadOnlyRoots roots, Object k);
+  // Returns whether k is a real key.  The hole and undefined are not allowed as
+  // keys and can be used to indicate missing or deleted elements.
+  static bool IsKey(ReadOnlyRoots roots, Object k) {
+    return Shape::IsKey(roots, k);
+  }
 
   inline bool ToKey(ReadOnlyRoots roots, InternalIndex entry, Object* out_k);
   inline bool ToKey(Isolate* isolate, InternalIndex entry, Object* out_k);