Commit 38ea6697 authored by Predrag Rudic's avatar Predrag Rudic Committed by Commit Bot

MIPS32: Mark ArraySpliceTorque as isolate dependent

This CL complements commit f2695f73
for MIPS32. That commit addressed problem for MIPS64.

Original message:
>ArraySpliceTorque builtin triggers generation of MIPS specific
>trampolines due to its large size, and this code is not PIC
>and cannot be isolate independent.
>
>This CL is a workaround that marks ArraySpliceTorque as
>isolate dependent on MIPS64.
>
>Bug: v8:7882
>Change-Id: I0b5764236268c2529e149b275dcf382dab709682
>Reviewed-on: https://chromium-review.googlesource.com/1111847
>Commit-Queue: Jakob Gruber <jgruber@chromium.org>
>Reviewed-by: Michael Stanton <mvstanton@chromium.org>
>Reviewed-by: Jakob Gruber <jgruber@chromium.org>
>Cr-Commit-Position: refs/heads/master@{#53968}

Bug: v8:7882
Change-Id: Iffdfab673781cca1eb14d11428ffcf7a01c21f27
Reviewed-on: https://chromium-review.googlesource.com/1117186
Commit-Queue: Sreten Kovacevic <sreten.kovacevic@mips.com>
Reviewed-by: 's avatarJakob Gruber <jgruber@chromium.org>
Reviewed-by: 's avatarMichael Stanton <mvstanton@chromium.org>
Cr-Commit-Position: refs/heads/master@{#54083}
parent cd5d72fd
...@@ -316,10 +316,11 @@ bool Builtins::IsIsolateIndependent(int index) { ...@@ -316,10 +316,11 @@ bool Builtins::IsIsolateIndependent(int index) {
// of the builtin itself (and not just the trampoline). // of the builtin itself (and not just the trampoline).
case kInterpreterEntryTrampoline: case kInterpreterEntryTrampoline:
return false; return false;
#if V8_TARGET_ARCH_MIPS64 #if V8_TARGET_ARCH_MIPS64 || V8_TARGET_ARCH_MIPS
// TODO(7882): The size of ArraySpliceTorque on MIP64 is greater than 128KB, // TODO(7882): The size of ArraySpliceTorque on MIP64 and MIPS32 is greater
// and this triggers generation of MIPS specific trampolines. Trampoline // than 128KB, and this triggers generation of MIPS specific trampolines.
// code is not PIC and therefore the builtin is not isolate independent. // Trampoline code is not PIC and therefore the builtin is not isolate
// independent.
case kArraySpliceTorque: case kArraySpliceTorque:
return false; return false;
#endif #endif
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment