[wasm] Rework CALL_INTERFACE macros in WasmDecoder
Main change: Remove CALL_INTERFACE macro. Use CALL_INTERFACE_IF_REACHABLE or invoke interface directly instead. Reasoning: Interfaces assume the Decoder is in a non-error state, therefore CALL_INTERFACE invoked DCHECK(this->ok()). However, CALL_INTERFACE (1) was sometimes erroneously called with an error in the decoder, especially in cases where the error occurred inside immediate argument parsing, (2) was always called in contexts where the current control was guaranteed to be reachable. Due to (1) and (2), CALL_INTERFACE is equivalent to CALL_INTERFACE_IF_REACHABLE (there are a few exceptions where we can call the interface directly). Additional change: - Rename current_code_reachable_ to current_code_reachable_and_ok_ to make its name reflect its meaning better. Bug: chromium:1194784 Change-Id: I52055161a802e6981506b2a8dc8bb8233198aa2c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2799351 Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Reviewed-by: Thibaud Michaud <thibaudm@chromium.org> Cr-Commit-Position: refs/heads/master@{#73771}
Showing
This diff is collapsed.
Please
register
or
sign in
to comment