Commit 371580bb authored by Clemens Backes's avatar Clemens Backes Committed by Commit Bot

[wasm] Improve error message for missing Liftoff support

Complete Liftoff support is needed for debugging. In case of a bailout
from Liftoff, produce a better error message, also in release builds.

R=thibaudm@chromium.org

Bug: v8:10147
Change-Id: I8cdb11a5c54f9101ea611e28dd3fb7dc4fe5c538
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2105633Reviewed-by: 's avatarThibaud Michaud <thibaudm@chromium.org>
Commit-Queue: Clemens Backes <clemensb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#66730}
parent 81d8e42f
......@@ -631,7 +631,9 @@ class DebugInfoImpl {
result = ExecuteLiftoffCompilation(native_module_->engine()->allocator(),
&env, body, func_index, nullptr, nullptr,
offsets, &debug_sidetable);
DCHECK(result.succeeded());
// Liftoff compilation failure is a FATAL error. We rely on complete Liftoff
// support for debugging.
if (!result.succeeded()) FATAL("Liftoff compilation failed");
DCHECK_NOT_NULL(debug_sidetable);
WasmCodeRefScope wasm_code_ref_scope;
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment