Commit 3710fd4a authored by Marja Hölttä's avatar Marja Hölttä Committed by Commit Bot

Revert "[parser] Tentative: turn on FLAG_preparser_scope_analysis."

This reverts commit fe50e817.

Reason for revert: Too close to branch point

Original change's description:
> [parser] Tentative: turn on FLAG_preparser_scope_analysis.
> 
> The main motivation is to get bug reports / crashes from Canary.
> 
> This commit is expected to break all kinds of things! The most typical failure
> modes are crashes, CHECK failures and JavaScript executing incorrectly.
> 
> BUG=v8:5516
> 
> Change-Id: Ifa02b420ad4e8eda46002b334bed2665c8ceeeb2
> Reviewed-on: https://chromium-review.googlesource.com/623751
> Reviewed-by: Camillo Bruni <cbruni@chromium.org>
> Commit-Queue: Marja Hölttä <marja@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#47502}

TBR=adamk@chromium.org,marja@chromium.org,cbruni@chromium.org

Change-Id: I98d2d186cbde6e185b05ef0d3460115a654b6b45
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: v8:5516
Reviewed-on: https://chromium-review.googlesource.com/626796Reviewed-by: 's avatarMarja Hölttä <marja@chromium.org>
Commit-Queue: Marja Hölttä <marja@chromium.org>
Cr-Commit-Position: refs/heads/master@{#47519}
parent 000ef276
...@@ -867,7 +867,7 @@ DEFINE_BOOL(lazy_inner_functions, true, "enable lazy parsing inner functions") ...@@ -867,7 +867,7 @@ DEFINE_BOOL(lazy_inner_functions, true, "enable lazy parsing inner functions")
DEFINE_BOOL(aggressive_lazy_inner_functions, false, DEFINE_BOOL(aggressive_lazy_inner_functions, false,
"even lazier inner function parsing") "even lazier inner function parsing")
DEFINE_IMPLICATION(aggressive_lazy_inner_functions, lazy_inner_functions) DEFINE_IMPLICATION(aggressive_lazy_inner_functions, lazy_inner_functions)
DEFINE_BOOL(preparser_scope_analysis, true, DEFINE_BOOL(preparser_scope_analysis, false,
"perform scope analysis for preparsed inner functions") "perform scope analysis for preparsed inner functions")
DEFINE_IMPLICATION(preparser_scope_analysis, aggressive_lazy_inner_functions) DEFINE_IMPLICATION(preparser_scope_analysis, aggressive_lazy_inner_functions)
......
...@@ -248,21 +248,21 @@ KNOWN_MAPS = { ...@@ -248,21 +248,21 @@ KNOWN_MAPS = {
0x03f39: (190, "ExternalMap"), 0x03f39: (190, "ExternalMap"),
0x03f91: (106, "NativeSourceStringMap"), 0x03f91: (106, "NativeSourceStringMap"),
0x03fe9: (152, "InterceptorInfoMap"), 0x03fe9: (152, "InterceptorInfoMap"),
0x04041: (164, "Tuple2Map"), 0x04041: (208, "JSPromiseCapabilityMap"),
0x04099: (208, "JSPromiseCapabilityMap"), 0x04099: (149, "AccessorInfoMap"),
0x040f1: (149, "AccessorInfoMap"), 0x040f1: (150, "AccessorPairMap"),
0x04149: (150, "AccessorPairMap"), 0x04149: (151, "AccessCheckInfoMap"),
0x041a1: (151, "AccessCheckInfoMap"), 0x041a1: (153, "FunctionTemplateInfoMap"),
0x041f9: (153, "FunctionTemplateInfoMap"), 0x041f9: (154, "ObjectTemplateInfoMap"),
0x04251: (154, "ObjectTemplateInfoMap"), 0x04251: (155, "AllocationSiteMap"),
0x042a9: (155, "AllocationSiteMap"), 0x042a9: (156, "AllocationMementoMap"),
0x04301: (156, "AllocationMementoMap"), 0x04301: (158, "AliasedArgumentsEntryMap"),
0x04359: (158, "AliasedArgumentsEntryMap"), 0x04359: (159, "PromiseResolveThenableJobInfoMap"),
0x043b1: (159, "PromiseResolveThenableJobInfoMap"), 0x043b1: (160, "PromiseReactionJobInfoMap"),
0x04409: (160, "PromiseReactionJobInfoMap"), 0x04409: (161, "DebugInfoMap"),
0x04461: (161, "DebugInfoMap"), 0x04461: (162, "StackFrameInfoMap"),
0x044b9: (162, "StackFrameInfoMap"), 0x044b9: (163, "PrototypeInfoMap"),
0x04511: (163, "PrototypeInfoMap"), 0x04511: (164, "Tuple2Map"),
0x04569: (165, "Tuple3Map"), 0x04569: (165, "Tuple3Map"),
0x045c1: (166, "ContextExtensionMap"), 0x045c1: (166, "ContextExtensionMap"),
0x04619: (167, "ModuleMap"), 0x04619: (167, "ModuleMap"),
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment