[test] Suppress subobject-linkage warnings

Currently there are a number of -Wsubobject-linkage warnings when
compiling with gcc (formatted to fit 72 character lines):

In file included from
...
from ../../testing/gtest/include/gtest/gtest.h:10,
from ../../testing/gtest-support.h:8,
from ../../test/unittests/test-utils.h:20,
from ../../test/unittests/compiler/backend/
  instruction-selector-unittest.h:15,
from ../../test/unittests/compiler/x64/
  instruction-selector-x64-unittest.cc:9:
../../third_party/googletest/src/googletest/include/gtest/internal/
gtest-param-util.h:
In instantiation of ‘class
testing::internal::ParameterizedTestFactory<v8::internal::compiler::
InstructionSelectorChangeInt32ToInt64Test_ \
ChangeInt32ToInt64WithLoad_Test>’:
../../third_party/googletest/src/googletest/include/gtest/internal/
gtest-param-util.h:439:12:   required from
‘testing::internal::TestFactoryBase*
testing::internal::TestMetaFactory<TestSuite>::CreateTestFactory(
  testing::internal::TestMetaFactory<TestSuite>::ParamType)
[with
TestSuite = v8::internal::compiler::
InstructionSelectorChangeInt32ToInt64Test_ \
ChangeInt32ToInt64WithLoad_Test;
testing::internal::TestMetaFactory<TestSuite>::ParamType =
  v8::internal::compiler::{anonymous}::LoadWithToInt64Extension]’
../../third_party/googletest/src/googletest/include/gtest/internal/
  gtest-param-util.h:438:20:   required from here
../../third_party/googletest/src/googletest/include/gtest/internal/
  gtest-param-util.h:394:7: warning:
‘testing::internal::ParameterizedTestFactory<
v8::internal::compiler::
InstructionSelectorChangeInt32ToInt64Test_ \
ChangeInt32ToInt64WithLoad_Test >’ has a field
‘testing::internal::ParameterizedTestFactory<
v8::internal::compiler::
InstructionSelectorChangeInt32ToInt64Test_ \
ChangeInt32ToInt64WithLoad_Test>::parameter_’ whose type uses the
anonymous namespace [-Wsubobject-linkage]
  394 | class ParameterizedTestFactory : public TestFactoryBase {
      |       ^~~~~~~~~~~~~~~~~~~~~~~~

This commit moves the parameterized tests in question into the
anonymous namespace to avoid the warnings.

Change-Id: I9c4a8bd9f4e225ed14ab64f5433d5f5c102e01a1
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2418723Reviewed-by: Andreas Haas <ahaas@chromium.org>
Commit-Queue: Andreas Haas <ahaas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#70482}

test/unittests/compiler/x64/instruction-selector-x64-unittest.cc

@@ -90,8 +90,14 @@ static const LoadWithToInt64Extension kLoadWithToInt64Extensions[] = {
     {MachineType::Uint16(), kX64Movzxwq},
     {MachineType::Int32(), kX64Movsxlq}};
 
-}  // namespace
-
+// The parameterized test that use the following type are intentionally part
+// of the anonymous namespace. The issue here is that the type parameter is
+// using a type that is in the anonymous namespace, but the class generated by
+// TEST_P is not. This will cause GCC to generate a -Wsubobject-linkage warning.
+//
+// In this case there will only be single translation unit and the warning
+// about subobject-linkage can be avoided by placing the class generated
+// by TEST_P in the anoynmous namespace as well.
 using InstructionSelectorChangeInt32ToInt64Test =
     InstructionSelectorTestWithParam<LoadWithToInt64Extension>;
 
@@ -104,6 +110,8 @@ TEST_P(InstructionSelectorChangeInt32ToInt64Test, ChangeInt32ToInt64WithLoad) {
   EXPECT_EQ(extension.expected_opcode, s[0]->arch_opcode());
 }
 
+}  // namespace
+
 INSTANTIATE_TEST_SUITE_P(InstructionSelectorTest,
                          InstructionSelectorChangeInt32ToInt64Test,
                          ::testing::ValuesIn(kLoadWithToInt64Extensions));
@@ -138,8 +146,14 @@ static const MemoryAccess kMemoryAccesses[] = {
     {MachineType::Float32(), kX64Movss, kX64Movss},
     {MachineType::Float64(), kX64Movsd, kX64Movsd}};
 
-}  // namespace
-
+// The parameterized test that use the following type are intentionally part
+// of the anonymous namespace. The issue here is that the type parameter is
+// using a type that is in the anonymous namespace, but the class generated by
+// TEST_P is not. This will cause GCC to generate a -Wsubobject-linkage warning.
+//
+// In this case there will only be single translation unit and the warning
+// about subobject-linkage can be avoided by placing the class generated
+// by TEST_P in the anoynmous namespace as well.
 using InstructionSelectorMemoryAccessTest =
     InstructionSelectorTestWithParam<MemoryAccess>;
 
@@ -170,6 +184,8 @@ TEST_P(InstructionSelectorMemoryAccessTest, StoreWithParameters) {
   EXPECT_EQ(0U, s[0]->OutputCount());
 }
 
+}  // namespace
+
 INSTANTIATE_TEST_SUITE_P(InstructionSelectorTest,
                          InstructionSelectorMemoryAccessTest,
                          ::testing::ValuesIn(kMemoryAccesses));
@@ -215,8 +231,14 @@ const BinaryOperation kWord32BinaryOperations[] = {
     {&RawMachineAssembler::Uint32LessThanOrEqual, "Uint32LessThanOrEqual"},
     {&RawMachineAssembler::Uint32Mod, "Uint32Mod"}};
 
-}  // namespace
-
+// The parameterized test that use the following type are intentionally part
+// of the anonymous namespace. The issue here is that the type parameter is
+// using a type that is in the anonymous namespace, but the class generated by
+// TEST_P is not. This will cause GCC to generate a -Wsubobject-linkage warning.
+//
+// In this case there will only be single translation unit and the warning
+// about subobject-linkage can be avoided by placing the class generated
+// by TEST_P in the anoynmous namespace as well.
 using InstructionSelectorChangeUint32ToUint64Test =
     InstructionSelectorTestWithParam<BinaryOperation>;
 
@@ -231,6 +253,8 @@ TEST_P(InstructionSelectorChangeUint32ToUint64Test, ChangeUint32ToUint64) {
   ASSERT_EQ(1U, s.size());
 }
 
+}  // namespace
+
 INSTANTIATE_TEST_SUITE_P(InstructionSelectorTest,
                          InstructionSelectorChangeUint32ToUint64Test,
                          ::testing::ValuesIn(kWord32BinaryOperations));
@@ -294,8 +318,14 @@ const MachInst2 kCanElideChangeUint32ToUint64[] = {
      MachineType::Uint32()},
 };
 
-}  // namespace
-
+// The parameterized test that use the following type are intentionally part
+// of the anonymous namespace. The issue here is that the type parameter is
+// using a type that is in the anonymous namespace, but the class generated by
+// TEST_P is not. This will cause GCC to generate a -Wsubobject-linkage warning.
+//
+// In this case there will only be single translation unit and the warning
+// about subobject-linkage can be avoided by placing the class generated
+// by TEST_P in the anoynmous namespace as well.
 using InstructionSelectorElidedChangeUint32ToUint64Test =
     InstructionSelectorTestWithParam<MachInst2>;
 
@@ -313,6 +343,8 @@ TEST_P(InstructionSelectorElidedChangeUint32ToUint64Test, Parameter) {
   EXPECT_EQ(1U, s[0]->OutputCount());
 }
 
+}  // namespace
+
 INSTANTIATE_TEST_SUITE_P(InstructionSelectorTest,
                          InstructionSelectorElidedChangeUint32ToUint64Test,
                          ::testing::ValuesIn(kCanElideChangeUint32ToUint64));