Commit 3700a01c authored by jbroman's avatar jbroman Committed by Commit bot

Make v8::Eternal::Get and IsEmpty const.

They do not modify the state of the handle.

Review-Url: https://codereview.chromium.org/2753973002
Cr-Commit-Position: refs/heads/master@{#43907}
parent 9f720a68
...@@ -366,8 +366,8 @@ template <class T> class Eternal { ...@@ -366,8 +366,8 @@ template <class T> class Eternal {
Set(isolate, handle); Set(isolate, handle);
} }
// Can only be safely called if already set. // Can only be safely called if already set.
V8_INLINE Local<T> Get(Isolate* isolate); V8_INLINE Local<T> Get(Isolate* isolate) const;
V8_INLINE bool IsEmpty() { return index_ == kInitialValue; } V8_INLINE bool IsEmpty() const { return index_ == kInitialValue; }
template<class S> V8_INLINE void Set(Isolate* isolate, Local<S> handle); template<class S> V8_INLINE void Set(Isolate* isolate, Local<S> handle);
private: private:
...@@ -8644,9 +8644,8 @@ void Eternal<T>::Set(Isolate* isolate, Local<S> handle) { ...@@ -8644,9 +8644,8 @@ void Eternal<T>::Set(Isolate* isolate, Local<S> handle) {
V8::Eternalize(isolate, reinterpret_cast<Value*>(*handle), &this->index_); V8::Eternalize(isolate, reinterpret_cast<Value*>(*handle), &this->index_);
} }
template <class T>
template<class T> Local<T> Eternal<T>::Get(Isolate* isolate) const {
Local<T> Eternal<T>::Get(Isolate* isolate) {
return Local<T>(reinterpret_cast<T*>(*V8::GetEternal(isolate, index_))); return Local<T>(reinterpret_cast<T*>(*V8::GetEternal(isolate, index_)));
} }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment