Commit 36e5b7b3 authored by Sergiy Byelozyorov's avatar Sergiy Byelozyorov Committed by Commit Bot

Revert "[test] Pass suite environment to Android test runner"

This reverts commit 18c90f48.

Reason for revert: needs to be reverted prior to https://crrev.com/c/1170962

Original change's description:
> [test] Pass suite environment to Android test runner
> 
> TBR=sergiyb@chromium.org
> 
> Bug: v8:8046
> Change-Id: I201f7a7ee119628e14c864602a2d3cbadfc4052b
> Reviewed-on: https://chromium-review.googlesource.com/1170779
> Reviewed-by: Sergiy Byelozyorov <sergiyb@chromium.org>
> Reviewed-by: Michael Achenbach <machenbach@chromium.org>
> Commit-Queue: Michael Achenbach <machenbach@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#55051}

TBR=machenbach@chromium.org,sergiyb@chromium.org

Change-Id: I2c874305251b8b73f3bc0aaaf31a81ef30d6c15d
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: v8:8046
Reviewed-on: https://chromium-review.googlesource.com/1171002Reviewed-by: 's avatarSergiy Byelozyorov <sergiyb@chromium.org>
Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#55056}
parent 7f3f7e8a
...@@ -647,8 +647,16 @@ ...@@ -647,8 +647,16 @@
# Precision: # Precision:
'es6/math-log2-log10': [FAIL], 'es6/math-log2-log10': [FAIL],
# Timezone issues: # Timezone issues:
'icu-date-lord-howe': [FAIL],
'icu-date-to-string': [FAIL], 'icu-date-to-string': [FAIL],
'regress/regress-6288': [FAIL], 'regress/regress-6288': [FAIL],
'tzoffset-seoul': [FAIL],
'tzoffset-seoul-noi18n': [FAIL],
'tzoffset-transition-apia': [FAIL],
'tzoffset-transition-lord-howe': [FAIL],
'tzoffset-transition-moscow': [FAIL],
'tzoffset-transition-new-york': [FAIL],
'tzoffset-transition-new-york-noi18n': [FAIL],
# OOM: # OOM:
'regress/regress-599414-array-concat-fast-path': [FAIL], 'regress/regress-599414-array-concat-fast-path': [FAIL],
'regress/regress-748069': [FAIL], 'regress/regress-748069': [FAIL],
......
...@@ -141,7 +141,7 @@ class _Driver(object): ...@@ -141,7 +141,7 @@ class _Driver(object):
skip_if_missing=True, skip_if_missing=True,
) )
def run(self, target_dir, binary, args, env, rel_path, timeout): def run(self, target_dir, binary, args, rel_path, timeout):
"""Execute a command on the device's shell. """Execute a command on the device's shell.
Args: Args:
...@@ -149,7 +149,6 @@ class _Driver(object): ...@@ -149,7 +149,6 @@ class _Driver(object):
devices' base dir for testing). devices' base dir for testing).
binary: Name of the binary. binary: Name of the binary.
args: List of arguments to pass to the binary. args: List of arguments to pass to the binary.
env: The environment variables with which the command should be run.
rel_path: Relative path on device to use as CWD. rel_path: Relative path on device to use as CWD.
timeout: Timeout in seconds. timeout: Timeout in seconds.
""" """
...@@ -160,7 +159,6 @@ class _Driver(object): ...@@ -160,7 +159,6 @@ class _Driver(object):
cmd, cmd,
cwd=os.path.join(DEVICE_DIR, rel_path), cwd=os.path.join(DEVICE_DIR, rel_path),
check_return=True, check_return=True,
env=env,
timeout=timeout, timeout=timeout,
retries=0, retries=0,
) )
......
...@@ -249,7 +249,7 @@ class AndroidCommand(BaseCommand): ...@@ -249,7 +249,7 @@ class AndroidCommand(BaseCommand):
timed_out = False timed_out = False
try: try:
stdout = android_driver().run( stdout = android_driver().run(
'bin', self.shell_name, self.args, self.env, '.', self.timeout) 'bin', self.shell_name, self.args, '.', self.timeout)
except CommandFailedException as e: except CommandFailedException as e:
return_code = e.status return_code = e.status
stdout = e.output stdout = e.output
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment