Commit 366dc811 authored by machenbach's avatar machenbach Committed by Commit bot

[Swarming] Presort tests - slowest first.

Swarming won't support an incremental data file. By just
sorting the lowest hanging fruits to the beginning we
already get a big bang for the buck (>80% of the improvement
we get otherwise).

This will require semi-regular manual updates of the
slowest tests.

BUG=chromium:535160
LOG=n

Review URL: https://codereview.chromium.org/1385443002

Cr-Commit-Position: refs/heads/master@{#31061}
parent 0dedff6b
...@@ -28,8 +28,13 @@ ...@@ -28,8 +28,13 @@
[ [
[ALWAYS, { [ALWAYS, {
# Too slow in Debug mode. # Too slow in Debug mode.
'octane/mandreel': [PASS, ['mode == debug', SKIP]], 'octane/mandreel': [PASS, SLOW, ['mode == debug', SKIP]],
# TODO(turbofan): Too slow in debug mode for now. # TODO(turbofan): Too slow in debug mode for now.
'octane/pdfjs': [PASS, ['mode == debug', SKIP]], 'octane/pdfjs': [PASS, ['mode == debug', SKIP]],
# Slow tests.
'kraken/imaging-gaussian-blur': [PASS, SLOW],
'octane/mandreel': [PASS, SLOW],
'octane/typescript': [PASS, SLOW],
}], # ALWAYS }], # ALWAYS
] ]
...@@ -126,6 +126,7 @@ ...@@ -126,6 +126,7 @@
'test-api/Threading2': [PASS, ['mode == debug', SLOW]], 'test-api/Threading2': [PASS, ['mode == debug', SLOW]],
'test-api/Threading3': [PASS, ['mode == debug', SLOW]], 'test-api/Threading3': [PASS, ['mode == debug', SLOW]],
'test-api/Threading4': [PASS, ['mode == debug', SLOW]], 'test-api/Threading4': [PASS, ['mode == debug', SLOW]],
'test-debug/CallFunctionInDebugger': [PASS, ['mode == debug', SLOW]],
'test-strings/StringOOM*': [PASS, ['mode == debug', SKIP]], 'test-strings/StringOOM*': [PASS, ['mode == debug', SKIP]],
# TODO(machenbach, mvstanton): Flaky in debug on all platforms. # TODO(machenbach, mvstanton): Flaky in debug on all platforms.
...@@ -198,6 +199,10 @@ ...@@ -198,6 +199,10 @@
############################################################################## ##############################################################################
['no_snap == True', { ['no_snap == True', {
# Slow tests.
'test-api/ExternalWrap': [PASS, SLOW],
'test-api/FastReturnValues*': [PASS, SLOW],
'test-decls/CrossScriptReferences_Simple2': [PASS, SLOW],
}], # 'no_snap == True' }], # 'no_snap == True'
############################################################################## ##############################################################################
......
...@@ -197,7 +197,7 @@ ...@@ -197,7 +197,7 @@
# Skip long running tests that time out in debug mode. # Skip long running tests that time out in debug mode.
'generated-transition-stub': [PASS, ['mode == debug', SKIP]], 'generated-transition-stub': [PASS, ['mode == debug', SKIP]],
'migrations': [SKIP], 'migrations': [SKIP],
'array-functions-prototype-misc': [PASS, ['mode == debug', SKIP]], 'array-functions-prototype-misc': [PASS, SLOW, ['mode == debug', SKIP]],
############################################################################## ##############################################################################
# This test sets the umask on a per-process basis and hence cannot be # This test sets the umask on a per-process basis and hence cannot be
...@@ -251,6 +251,17 @@ ...@@ -251,6 +251,17 @@
# BUG(chromium:508074). Remove this once the issue is fixed. # BUG(chromium:508074). Remove this once the issue is fixed.
'harmony/arrow-rest-params': [PASS, NO_VARIANTS], 'harmony/arrow-rest-params': [PASS, NO_VARIANTS],
'harmony/rest-params': [PASS, ['no_snap == True', NO_VARIANTS]], 'harmony/rest-params': [PASS, ['no_snap == True', NO_VARIANTS]],
# Slow tests.
'copy-on-write-assert': [PASS, SLOW],
'debug-scopes': [PASS, SLOW],
'es7/object-observe': [PASS, ['mode == debug', SLOW]],
'numops-fuzz-part*': [PASS, ['mode == debug', SLOW]],
'readonly': [PASS, SLOW],
'regress/regress-1200351': [PASS, ['mode == debug', SLOW]],
'regress/regress-crbug-474297': [PASS, ['mode == debug', SLOW]],
'strong/implicit-conversions': [PASS, SLOW],
'strong/load-element-mutate-backing-store': [PASS, SLOW],
}], # ALWAYS }], # ALWAYS
['novfp3 == True', { ['novfp3 == True', {
...@@ -321,6 +332,12 @@ ...@@ -321,6 +332,12 @@
# BUG(v8:4381) # BUG(v8:4381)
'for-in-opt': [PASS, FAIL], 'for-in-opt': [PASS, FAIL],
# Slow tests.
'array-constructor': [PASS, SLOW],
'json': [PASS, SLOW],
'regress/regress-446389': [PASS, SLOW],
'regress/regress-inline-getter-near-stack-limit': [PASS, SLOW],
}], # 'gc_stress == True' }], # 'gc_stress == True'
############################################################################## ##############################################################################
......
...@@ -19,6 +19,10 @@ ...@@ -19,6 +19,10 @@
# TODO(bbudge): Drop this when simd implementation is faster. # TODO(bbudge): Drop this when simd implementation is faster.
'benchmarks/memcpy': SKIP, 'benchmarks/memcpy': SKIP,
# Slow tests.
'benchmarks/kernel-template': [PASS, SLOW],
'benchmarks/memset': [PASS, SLOW],
}], }],
###################################################################### ######################################################################
......
...@@ -72,6 +72,8 @@ class Runner(object): ...@@ -72,6 +72,8 @@ class Runner(object):
if not context.no_sorting: if not context.no_sorting:
for t in self.tests: for t in self.tests:
t.duration = self.perfdata.FetchPerfData(t) or 1.0 t.duration = self.perfdata.FetchPerfData(t) or 1.0
slow_key = lambda t: statusfile.IsSlow(t.outcomes)
self.tests.sort(key=slow_key, reverse=True)
self.tests.sort(key=lambda t: t.duration, reverse=True) self.tests.sort(key=lambda t: t.duration, reverse=True)
self._CommonInit(suites, progress_indicator, context) self._CommonInit(suites, progress_indicator, context)
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment