[cleanup][diagnostics] Remove redundant NOLINT annotations

cpplint rules change over time, and we change the exact rules we enable
for v8. This CL removes NOLINT annotations which are not needed
according to the currently enabled rules.

R=ahaas@chromium.org

Bug: v8:11717
Change-Id: I26e5a247bcca6c9638b97b220bc08098c5d7ce07
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2862780Reviewed-by: Andreas Haas <ahaas@chromium.org>
Commit-Queue: Clemens Backes <clemensb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#74444}

src/diagnostics/compilation-statistics.cc

@@ -2,11 +2,12 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-#include <ostream>  // NOLINT(readability/streams)
+#include "src/diagnostics/compilation-statistics.h"
+
+#include <ostream>
 #include <vector>
 
 #include "src/base/platform/platform.h"
-#include "src/diagnostics/compilation-statistics.h"
 
 namespace v8 {
 namespace internal {

src/diagnostics/eh-frame.cc

@@ -55,7 +55,7 @@ STATIC_CONST_MEMBER_DEFINITION const int EhFrameConstants::kEhFrameHdrSize;
 STATIC_CONST_MEMBER_DEFINITION const uint32_t EhFrameWriter::kInt32Placeholder;
 
 // static
-void EhFrameWriter::WriteEmptyEhFrame(std::ostream& stream) {  // NOLINT
+void EhFrameWriter::WriteEmptyEhFrame(std::ostream& stream) {
   stream.put(EhFrameConstants::kEhFrameHdrVersion);
 
   // .eh_frame pointer encoding specifier.
@@ -480,7 +480,7 @@ class V8_NODISCARD StreamModifiersScope final {
 }  // namespace
 
 // static
-void EhFrameDisassembler::DumpDwarfDirectives(std::ostream& stream,  // NOLINT
+void EhFrameDisassembler::DumpDwarfDirectives(std::ostream& stream,
                                               const byte* start,
                                               const byte* end) {
   StreamModifiersScope modifiers_scope(&stream);
@@ -592,7 +592,7 @@ void EhFrameDisassembler::DumpDwarfDirectives(std::ostream& stream,  // NOLINT
   }
 }
 
-void EhFrameDisassembler::DisassembleToStream(std::ostream& stream) {  // NOLINT
+void EhFrameDisassembler::DisassembleToStream(std::ostream& stream) {
   // The encoded CIE size does not include the size field itself.
   const int cie_size =
       base::ReadUnalignedValue<uint32_t>(reinterpret_cast<Address>(start_)) +

src/diagnostics/eh-frame.h

@@ -80,7 +80,7 @@ class V8_EXPORT_PRIVATE EhFrameWriter {
   //
   // It is effectively a valid eh_frame_hdr with an empty look up table.
   //
-  static void WriteEmptyEhFrame(std::ostream& stream);  // NOLINT
+  static void WriteEmptyEhFrame(std::ostream& stream);
 
   // Write the CIE and FDE header. Call it before any other method.
   void Initialize();
@@ -293,11 +293,11 @@ class EhFrameDisassembler final {
   EhFrameDisassembler(const EhFrameDisassembler&) = delete;
   EhFrameDisassembler& operator=(const EhFrameDisassembler&) = delete;
 
-  void DisassembleToStream(std::ostream& stream);  // NOLINT
+  void DisassembleToStream(std::ostream& stream);
 
  private:
-  static void DumpDwarfDirectives(std::ostream& stream,  // NOLINT
-                                  const byte* start, const byte* end);
+  static void DumpDwarfDirectives(std::ostream& stream, const byte* start,
+                                  const byte* end);
 
   static const char* DwarfRegisterCodeToString(int code);
 

src/diagnostics/ia32/disasm-ia32.cc

@@ -2890,7 +2890,7 @@ int DisassemblerIA32::InstructionDecode(v8::internal::Vector<char> out_buffer,
 
   outp += v8::internal::SNPrintF(out_buffer + outp, " %s", tmp_buffer_.begin());
   return instr_len;
-}  // NOLINT (function is too long)
+}
 
 //------------------------------------------------------------------------------