Commit 33b93f3d authored by Leszek Swirski's avatar Leszek Swirski Committed by Commit Bot

Revert "[ptr-compr][arm64] Temporarily enable pointer compression on arm64"

This reverts commit f5611402.

Reason for revert: arm64 sim MSAN failures (https://ci.chromium.org/p/v8/builders/ci/V8%20Linux%20-%20arm64%20-%20sim%20-%20MSAN/28059)

Original change's description:
> [ptr-compr][arm64] Temporarily enable pointer compression on arm64
> 
> ... and make sure that the arm64 ptr-compr bots proceed testing V8 without
> pointer compression in order to keep testing the other config.
> 
> Commented out the 'extra' variant since it was crashing. Opened a bug
> regarding that: https://bugs.chromium.org/p/v8/issues/detail?id=9568
> 
> Similar to x64's https://chromium-review.googlesource.com/c/v8/v8/+/1607654
> 
> Bug: v8:7703
> Change-Id: Ifd46b029bab34524f9f536dcdbd1574f2ddcbf37
> Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1724216
> Reviewed-by: Tamer Tas <tmrts@chromium.org>
> Reviewed-by: Michael Achenbach <machenbach@chromium.org>
> Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#63019}

TBR=machenbach@chromium.org,tmrts@chromium.org,solanes@chromium.org

Change-Id: I7d96c8aa83fcabff7e9a82e0556811398fedc34c
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: v8:7703
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1730994Reviewed-by: 's avatarLeszek Swirski <leszeks@chromium.org>
Commit-Queue: Leszek Swirski <leszeks@chromium.org>
Cr-Commit-Position: refs/heads/master@{#63022}
parent 51d1573b
...@@ -107,7 +107,7 @@ declare_args() { ...@@ -107,7 +107,7 @@ declare_args() {
v8_enable_verify_csa = false v8_enable_verify_csa = false
# Enable pointer compression (sets -dV8_COMPRESS_POINTERS). # Enable pointer compression (sets -dV8_COMPRESS_POINTERS).
v8_enable_pointer_compression = "" v8_enable_pointer_compression = false
v8_enable_31bit_smis_on_64bit_arch = false v8_enable_31bit_smis_on_64bit_arch = false
# Sets -dOBJECT_PRINT. # Sets -dOBJECT_PRINT.
...@@ -218,10 +218,6 @@ if (v8_check_microtasks_scopes_consistency == "") { ...@@ -218,10 +218,6 @@ if (v8_check_microtasks_scopes_consistency == "") {
if (v8_enable_snapshot_native_code_counters == "") { if (v8_enable_snapshot_native_code_counters == "") {
v8_enable_snapshot_native_code_counters = v8_enable_debugging_features v8_enable_snapshot_native_code_counters = v8_enable_debugging_features
} }
if (v8_enable_pointer_compression == "") {
# TODO(v8:v7703): temporarily enable pointer compression on arm64
v8_enable_pointer_compression = v8_current_cpu == "arm64"
}
if (v8_enable_shared_ro_heap == "") { if (v8_enable_shared_ro_heap == "") {
v8_enable_shared_ro_heap = !v8_enable_pointer_compression && v8_use_snapshot v8_enable_shared_ro_heap = !v8_enable_pointer_compression && v8_use_snapshot
} }
......
...@@ -369,11 +369,8 @@ ...@@ -369,11 +369,8 @@
'release_simulate_arm64': [ 'release_simulate_arm64': [
'release_bot', 'simulate_arm64'], 'release_bot', 'simulate_arm64'],
'release_simulate_arm64_pointer_compression': [ 'release_simulate_arm64_pointer_compression': [
# TODO(v8:v7703): Make pointer compression bots testing non pointer
# compression mode while pointer compression is temporarily enabled
# on arm64
'release_bot', 'simulate_arm64', 'dcheck_always_on', 'release_bot', 'simulate_arm64', 'dcheck_always_on',
'v8_enable_slow_dchecks', 'v8_disable_pointer_compression'], 'v8_enable_slow_dchecks', 'v8_enable_pointer_compression'],
'release_simulate_arm64_msan': [ 'release_simulate_arm64_msan': [
'release_bot', 'simulate_arm64', 'msan'], 'release_bot', 'simulate_arm64', 'msan'],
'release_simulate_arm64_msan_minimal_symbols': [ 'release_simulate_arm64_msan_minimal_symbols': [
...@@ -822,10 +819,6 @@ ...@@ -822,10 +819,6 @@
'gn_args': 'v8_enable_pointer_compression=true', 'gn_args': 'v8_enable_pointer_compression=true',
}, },
'v8_disable_pointer_compression': {
'gn_args': 'v8_enable_pointer_compression=false',
},
'v8_enable_test_features': { 'v8_enable_test_features': {
'gn_args': 'v8_enable_test_features=true', 'gn_args': 'v8_enable_test_features=true',
}, },
......
...@@ -454,9 +454,7 @@ ...@@ -454,9 +454,7 @@
{'name': 'mozilla', 'shards': 2}, {'name': 'mozilla', 'shards': 2},
{'name': 'test262', 'shards': 2}, {'name': 'test262', 'shards': 2},
{'name': 'v8testing', 'shards': 10}, {'name': 'v8testing', 'shards': 10},
# TODO(v8:v7703): Temporarily disable this test while enabling pointer {'name': 'v8testing', 'variant': 'extra', 'shards': 6},
# compression on arm64.
# {'name': 'v8testing', 'variant': 'extra', 'shards': 6},
{'name': 'v8testing', 'variant': 'trusted', 'shards': 3}, {'name': 'v8testing', 'variant': 'trusted', 'shards': 3},
], ],
}, },
...@@ -477,9 +475,7 @@ ...@@ -477,9 +475,7 @@
{'name': 'mozilla', 'shards': 2}, {'name': 'mozilla', 'shards': 2},
{'name': 'test262', 'shards': 2}, {'name': 'test262', 'shards': 2},
{'name': 'v8testing', 'shards': 12}, {'name': 'v8testing', 'shards': 12},
# TODO(v8:v7703): Temporarily disable this test while enabling pointer {'name': 'v8testing', 'variant': 'extra', 'shards': 8},
# compression on arm64.
# {'name': 'v8testing', 'variant': 'extra', 'shards': 8},
{'name': 'v8testing', 'variant': 'trusted', 'shards': 3}, {'name': 'v8testing', 'variant': 'trusted', 'shards': 3},
], ],
}, },
...@@ -1471,9 +1467,7 @@ ...@@ -1471,9 +1467,7 @@
{'name': 'mozilla'}, {'name': 'mozilla'},
{'name': 'test262'}, {'name': 'test262'},
{'name': 'v8testing', 'shards': 3}, {'name': 'v8testing', 'shards': 3},
# TODO(v8:v7703): Temporarily disable this test while enabling pointer {'name': 'v8testing', 'variant': 'extra'},
# compression on arm64.
# {'name': 'v8testing', 'variant': 'extra'},
{'name': 'v8testing', 'variant': 'trusted'}, {'name': 'v8testing', 'variant': 'trusted'},
], ],
}, },
...@@ -1490,9 +1484,7 @@ ...@@ -1490,9 +1484,7 @@
{'name': 'mozilla', 'shards': 2}, {'name': 'mozilla', 'shards': 2},
{'name': 'test262', 'shards': 2}, {'name': 'test262', 'shards': 2},
{'name': 'v8testing', 'shards': 10}, {'name': 'v8testing', 'shards': 10},
# TODO(v8:v7703): Temporarily disable this test while enabling pointer {'name': 'v8testing', 'variant': 'extra', 'shards': 6},
# compression on arm64.
# {'name': 'v8testing', 'variant': 'extra', 'shards': 6},
{'name': 'v8testing', 'variant': 'trusted', 'shards': 2}, {'name': 'v8testing', 'variant': 'trusted', 'shards': 2},
], ],
}, },
......
...@@ -785,6 +785,7 @@ ...@@ -785,6 +785,7 @@
'icu-date-lord-howe': [SKIP], 'icu-date-lord-howe': [SKIP],
'regress/regress-6288': [SKIP], 'regress/regress-6288': [SKIP],
# OOM: # OOM:
'regress/regress-748069': [FAIL],
'regress/regress-752764': [FAIL], 'regress/regress-752764': [FAIL],
# Flaky OOM: # Flaky OOM:
'regress/regress-779407': [SKIP], 'regress/regress-779407': [SKIP],
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment