Commit 338869fc authored by Adam Klein's avatar Adam Klein Committed by V8 LUCI CQ

[temporal] Use const ref consistently for std::vector arguments

Change-Id: I7ecdfa6ee865d87851bf1975ddd48bd0bfcd39ba
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3805822Reviewed-by: 's avatarFrank Tang <ftang@chromium.org>
Commit-Queue: Adam Klein <adamk@chromium.org>
Cr-Commit-Position: refs/heads/main@{#82410}
parent cf765fc3
...@@ -47,7 +47,7 @@ MaybeHandle<JSReceiver> CoerceOptionsToObject(Isolate* isolate, ...@@ -47,7 +47,7 @@ MaybeHandle<JSReceiver> CoerceOptionsToObject(Isolate* isolate,
Maybe<bool> GetStringOption(Isolate* isolate, Handle<JSReceiver> options, Maybe<bool> GetStringOption(Isolate* isolate, Handle<JSReceiver> options,
const char* property, const char* property,
std::vector<const char*> values, const std::vector<const char*>& values,
const char* method_name, const char* method_name,
std::unique_ptr<char[]>* result) { std::unique_ptr<char[]>* result) {
Handle<String> property_str = Handle<String> property_str =
......
...@@ -36,7 +36,7 @@ V8_WARN_UNUSED_RESULT MaybeHandle<JSReceiver> CoerceOptionsToObject( ...@@ -36,7 +36,7 @@ V8_WARN_UNUSED_RESULT MaybeHandle<JSReceiver> CoerceOptionsToObject(
// printing the error message. // printing the error message.
V8_EXPORT_PRIVATE V8_WARN_UNUSED_RESULT Maybe<bool> GetStringOption( V8_EXPORT_PRIVATE V8_WARN_UNUSED_RESULT Maybe<bool> GetStringOption(
Isolate* isolate, Handle<JSReceiver> options, const char* property, Isolate* isolate, Handle<JSReceiver> options, const char* property,
std::vector<const char*> values, const char* method_name, const std::vector<const char*>& values, const char* method_name,
std::unique_ptr<char[]>* result); std::unique_ptr<char[]>* result);
// A helper template to get string from option into a enum. // A helper template to get string from option into a enum.
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment