Commit 32f32bdf authored by chunyang.dai's avatar chunyang.dai Committed by Commit bot

X87: Clean up JSConstructStub.

port 882055ff (r29082).

   The original CL covers part of X87 port. This CL addes the missing changes.

original commit message:

  - fix truthfulness of comments
    - use InitializeFieldsWithFiller more consistently
    - use unsigned comparisons for pointers

    No change in functionality intended.

    Bonus: improve JavaScriptFrame::Print() for an enhanced debugging experience:

BUG=

Review URL: https://codereview.chromium.org/1210153007

Cr-Commit-Position: refs/heads/master@{#29397}
parent 62572e01
...@@ -358,17 +358,9 @@ static void Generate_JSConstructStubHelper(MacroAssembler* masm, ...@@ -358,17 +358,9 @@ static void Generate_JSConstructStubHelper(MacroAssembler* masm,
// ebx: JSObject // ebx: JSObject
// edi: FixedArray // edi: FixedArray
// ecx: start of next object // ecx: start of next object
{ Label loop, entry;
__ mov(edx, factory->undefined_value()); __ mov(edx, factory->undefined_value());
__ lea(eax, Operand(edi, FixedArray::kHeaderSize)); __ lea(eax, Operand(edi, FixedArray::kHeaderSize));
__ jmp(&entry); __ InitializeFieldsWithFiller(eax, ecx, edx);
__ bind(&loop);
__ mov(Operand(eax, 0), edx);
__ add(eax, Immediate(kPointerSize));
__ bind(&entry);
__ cmp(eax, ecx);
__ j(below, &loop);
}
// Store the initialized FixedArray into the properties field of // Store the initialized FixedArray into the properties field of
// the JSObject // the JSObject
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment