Commit 321538c2 authored by Igor Sheludko's avatar Igor Sheludko Committed by Commit Bot

[cleanup] Make Isolate less friendly

Bug: v8:8238
Change-Id: I4bb14e4457b78b91a960680ab22c808b5f88052c
Reviewed-on: https://chromium-review.googlesource.com/c/1302053
Commit-Queue: Igor Sheludko <ishell@chromium.org>
Reviewed-by: 's avatarToon Verwaest <verwaest@chromium.org>
Cr-Commit-Position: refs/heads/master@{#57068}
parent f3a3e059
...@@ -622,6 +622,10 @@ class Isolate final : private HiddenFactory { ...@@ -622,6 +622,10 @@ class Isolate final : private HiddenFactory {
// at the same time, this should be prevented using external locking. // at the same time, this should be prevented using external locking.
void Exit(); void Exit();
// Find the PerThread for this particular (isolate, thread) combination.
// If one does not yet exist, allocate a new one.
PerIsolateThreadData* FindOrAllocatePerThreadDataForThisThread();
// Find the PerThread for this particular (isolate, thread) combination // Find the PerThread for this particular (isolate, thread) combination
// If one does not yet exist, return null. // If one does not yet exist, return null.
PerIsolateThreadData* FindPerThreadDataForThisThread(); PerIsolateThreadData* FindPerThreadDataForThisThread();
...@@ -1649,10 +1653,6 @@ class Isolate final : private HiddenFactory { ...@@ -1649,10 +1653,6 @@ class Isolate final : private HiddenFactory {
static void SetIsolateThreadLocals(Isolate* isolate, static void SetIsolateThreadLocals(Isolate* isolate,
PerIsolateThreadData* data); PerIsolateThreadData* data);
// Find the PerThread for this particular (isolate, thread) combination.
// If one does not yet exist, allocate a new one.
PerIsolateThreadData* FindOrAllocatePerThreadDataForThisThread();
void InitializeThreadLocal(); void InitializeThreadLocal();
void MarkCompactPrologue(bool is_compacting, void MarkCompactPrologue(bool is_compacting,
...@@ -1901,10 +1901,7 @@ class Isolate final : private HiddenFactory { ...@@ -1901,10 +1901,7 @@ class Isolate final : private HiddenFactory {
ThreadDataTable thread_data_table_; ThreadDataTable thread_data_table_;
friend class heap::HeapTester; friend class heap::HeapTester;
friend class Simulator;
friend class StackGuard;
friend class TestSerializer; friend class TestSerializer;
friend class ThreadManager;
DISALLOW_COPY_AND_ASSIGN(Isolate); DISALLOW_COPY_AND_ASSIGN(Isolate);
}; };
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment