Commit 30efbb06 authored by vitalyr@chromium.org's avatar vitalyr@chromium.org

Call binary op stub instead of runtime in count operations.

Review URL: http://codereview.chromium.org/1560001

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@4306 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
parent 3f208328
......@@ -7034,17 +7034,21 @@ void DeferredPrefixCountOperation::Generate() {
} else {
__ add(Operand(dst_), Immediate(Smi::FromInt(1)));
}
__ push(dst_);
if (!input_type_.IsNumber()) {
__ InvokeBuiltin(Builtins::TO_NUMBER, CALL_FUNCTION);
__ push(eax);
}
__ push(Immediate(Smi::FromInt(1)));
if (is_increment_) {
__ CallRuntime(Runtime::kNumberAdd, 2);
Register left;
if (input_type_.IsNumber()) {
left = dst_;
} else {
__ CallRuntime(Runtime::kNumberSub, 2);
__ push(dst_);
__ InvokeBuiltin(Builtins::TO_NUMBER, CALL_FUNCTION);
left = eax;
}
GenericBinaryOpStub stub(is_increment_ ? Token::ADD : Token::SUB,
NO_OVERWRITE,
NO_GENERIC_BINARY_FLAGS,
TypeInfo::Number());
stub.GenerateCall(masm_, left, Smi::FromInt(1));
if (!dst_.is(eax)) __ mov(dst_, eax);
}
......@@ -7084,23 +7088,23 @@ void DeferredPostfixCountOperation::Generate() {
} else {
__ add(Operand(dst_), Immediate(Smi::FromInt(1)));
}
Register left;
if (input_type_.IsNumber()) {
__ push(dst_); // Save the input to use as the old value.
__ push(dst_);
left = dst_;
} else {
__ push(dst_);
__ InvokeBuiltin(Builtins::TO_NUMBER, CALL_FUNCTION);
__ push(eax); // Save the result of ToNumber to use as the old value.
__ push(eax);
left = eax;
}
// Call the runtime for the addition or subtraction.
__ push(Immediate(Smi::FromInt(1)));
if (is_increment_) {
__ CallRuntime(Runtime::kNumberAdd, 2);
} else {
__ CallRuntime(Runtime::kNumberSub, 2);
}
GenericBinaryOpStub stub(is_increment_ ? Token::ADD : Token::SUB,
NO_OVERWRITE,
NO_GENERIC_BINARY_FLAGS,
TypeInfo::Number());
stub.GenerateCall(masm_, left, Smi::FromInt(1));
if (!dst_.is(eax)) __ mov(dst_, eax);
__ pop(old_);
}
......
......@@ -3152,17 +3152,21 @@ class DeferredPrefixCountOperation: public DeferredCode {
void DeferredPrefixCountOperation::Generate() {
__ push(dst_);
if (!input_type_.IsNumber()) {
__ InvokeBuiltin(Builtins::TO_NUMBER, CALL_FUNCTION);
__ push(rax);
}
__ Push(Smi::FromInt(1));
if (is_increment_) {
__ CallRuntime(Runtime::kNumberAdd, 2);
Register left;
if (input_type_.IsNumber()) {
left = dst_;
} else {
__ CallRuntime(Runtime::kNumberSub, 2);
__ push(dst_);
__ InvokeBuiltin(Builtins::TO_NUMBER, CALL_FUNCTION);
left = rax;
}
GenericBinaryOpStub stub(is_increment_ ? Token::ADD : Token::SUB,
NO_OVERWRITE,
NO_GENERIC_BINARY_FLAGS,
TypeInfo::Number());
stub.GenerateCall(masm_, left, Smi::FromInt(1));
if (!dst_.is(rax)) __ movq(dst_, rax);
}
......@@ -3196,23 +3200,23 @@ class DeferredPostfixCountOperation: public DeferredCode {
void DeferredPostfixCountOperation::Generate() {
Register left;
if (input_type_.IsNumber()) {
__ push(dst_); // Save the input to use as the old value.
__ push(dst_);
left = dst_;
} else {
__ push(dst_);
__ InvokeBuiltin(Builtins::TO_NUMBER, CALL_FUNCTION);
__ push(rax); // Save the result of ToNumber to use as the old value.
__ push(rax);
left = rax;
}
// Call the runtime for the addition or subtraction.
__ Push(Smi::FromInt(1));
if (is_increment_) {
__ CallRuntime(Runtime::kNumberAdd, 2);
} else {
__ CallRuntime(Runtime::kNumberSub, 2);
}
GenericBinaryOpStub stub(is_increment_ ? Token::ADD : Token::SUB,
NO_OVERWRITE,
NO_GENERIC_BINARY_FLAGS,
TypeInfo::Number());
stub.GenerateCall(masm_, left, Smi::FromInt(1));
if (!dst_.is(rax)) __ movq(dst_, rax);
__ pop(old_);
}
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment