Commit 30eb6e7e authored by Dan Elphick's avatar Dan Elphick Committed by Commit Bot

[api] Advance Object::Get/Set to V8_DEPRECATED

Bug: v8:7283, v8:9183
Change-Id: Idf7ddc20d0cb7da69f3458cf96935e426f454f34
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1569440Reviewed-by: 's avatarYang Guo <yangguo@chromium.org>
Commit-Queue: Yang Guo <yangguo@chromium.org>
Auto-Submit: Dan Elphick <delphick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#61060}
parent 715a6a9a
...@@ -3324,7 +3324,7 @@ enum class IntegrityLevel { kFrozen, kSealed }; ...@@ -3324,7 +3324,7 @@ enum class IntegrityLevel { kFrozen, kSealed };
*/ */
class V8_EXPORT Object : public Value { class V8_EXPORT Object : public Value {
public: public:
V8_DEPRECATE_SOON("Use maybe version", V8_DEPRECATED("Use maybe version",
bool Set(Local<Value> key, Local<Value> value)); bool Set(Local<Value> key, Local<Value> value));
/** /**
* Set only return Just(true) or Empty(), so if it should never fail, use * Set only return Just(true) or Empty(), so if it should never fail, use
...@@ -3333,7 +3333,7 @@ class V8_EXPORT Object : public Value { ...@@ -3333,7 +3333,7 @@ class V8_EXPORT Object : public Value {
V8_WARN_UNUSED_RESULT Maybe<bool> Set(Local<Context> context, V8_WARN_UNUSED_RESULT Maybe<bool> Set(Local<Context> context,
Local<Value> key, Local<Value> value); Local<Value> key, Local<Value> value);
V8_DEPRECATE_SOON("Use maybe version", V8_DEPRECATED("Use maybe version",
bool Set(uint32_t index, Local<Value> value)); bool Set(uint32_t index, Local<Value> value));
V8_WARN_UNUSED_RESULT Maybe<bool> Set(Local<Context> context, uint32_t index, V8_WARN_UNUSED_RESULT Maybe<bool> Set(Local<Context> context, uint32_t index,
Local<Value> value); Local<Value> value);
...@@ -3378,11 +3378,11 @@ class V8_EXPORT Object : public Value { ...@@ -3378,11 +3378,11 @@ class V8_EXPORT Object : public Value {
V8_WARN_UNUSED_RESULT Maybe<bool> DefineProperty( V8_WARN_UNUSED_RESULT Maybe<bool> DefineProperty(
Local<Context> context, Local<Name> key, PropertyDescriptor& descriptor); Local<Context> context, Local<Name> key, PropertyDescriptor& descriptor);
V8_DEPRECATE_SOON("Use maybe version", Local<Value> Get(Local<Value> key)); V8_DEPRECATED("Use maybe version", Local<Value> Get(Local<Value> key));
V8_WARN_UNUSED_RESULT MaybeLocal<Value> Get(Local<Context> context, V8_WARN_UNUSED_RESULT MaybeLocal<Value> Get(Local<Context> context,
Local<Value> key); Local<Value> key);
V8_DEPRECATE_SOON("Use maybe version", Local<Value> Get(uint32_t index)); V8_DEPRECATED("Use maybe version", Local<Value> Get(uint32_t index));
V8_WARN_UNUSED_RESULT MaybeLocal<Value> Get(Local<Context> context, V8_WARN_UNUSED_RESULT MaybeLocal<Value> Get(Local<Context> context,
uint32_t index); uint32_t index);
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment