Commit 309dac5f authored by Leszek Swirski's avatar Leszek Swirski Committed by V8 LUCI CQ

Revert "[baseline] Add max threads flags for CSP"

This reverts commit 6aadf0e0.

Reason for revert: Maybe add arm64 mac to the CQ next time :) https://ci.chromium.org/ui/p/v8/builders/ci/V8%20Mac%20-%20arm64%20-%20release%20builder/7729/overview

Original change's description:
> [baseline] Add max threads flags for CSP
>
> Bug: v8:12054
> Change-Id: I49238fe673858b60c2a2a935ed1f45f465269216
> Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3308707
> Auto-Submit: Victor Gomes <victorgomes@chromium.org>
> Commit-Queue: Camillo Bruni <cbruni@chromium.org>
> Reviewed-by: Camillo Bruni <cbruni@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#78187}

Bug: v8:12054
Change-Id: I1b53ea3eaaaa39cdb1b9a471aa716b5af7f5e3d6
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3310838
Auto-Submit: Leszek Swirski <leszeks@chromium.org>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#78188}
parent 6aadf0e0
...@@ -9,8 +9,6 @@ ...@@ -9,8 +9,6 @@
#include "src/flags/flags.h" #include "src/flags/flags.h"
#if ENABLE_SPARKPLUG #if ENABLE_SPARKPLUG
#include <algorithm>
#include "src/baseline/baseline-compiler.h" #include "src/baseline/baseline-compiler.h"
#include "src/codegen/compiler.h" #include "src/codegen/compiler.h"
#include "src/execution/isolate.h" #include "src/execution/isolate.h"
...@@ -183,10 +181,6 @@ class ConcurrentBaselineCompiler { ...@@ -183,10 +181,6 @@ class ConcurrentBaselineCompiler {
} }
size_t GetMaxConcurrency(size_t worker_count) const override { size_t GetMaxConcurrency(size_t worker_count) const override {
size_t max_threads = FLAG_concurrent_sparkplug_max_threads;
if (max_threads > 0) {
return std::min(max_threads, incoming_queue_->size());
}
return incoming_queue_->size(); return incoming_queue_->size();
} }
......
...@@ -709,9 +709,6 @@ DEFINE_BOOL_READONLY(concurrent_sparkplug, false, ...@@ -709,9 +709,6 @@ DEFINE_BOOL_READONLY(concurrent_sparkplug, false,
#else #else
DEFINE_BOOL(concurrent_sparkplug, false, DEFINE_BOOL(concurrent_sparkplug, false,
"compile Sparkplug code in a background thread") "compile Sparkplug code in a background thread")
DEFINE_UINT(
concurrent_sparkplug_max_threads, 0,
"max number of threads that concurrent Sparkplug can use (0 for unbounded)")
DEFINE_WEAK_IMPLICATION(future, concurrent_sparkplug) DEFINE_WEAK_IMPLICATION(future, concurrent_sparkplug)
DEFINE_NEG_IMPLICATION(predictable, concurrent_sparkplug) DEFINE_NEG_IMPLICATION(predictable, concurrent_sparkplug)
DEFINE_NEG_IMPLICATION(single_threaded, concurrent_sparkplug) DEFINE_NEG_IMPLICATION(single_threaded, concurrent_sparkplug)
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment