Commit 30959b20 authored by ager@chromium.org's avatar ager@chromium.org

Update x64 RecordWrite comment. When the offset is zero the index

should be an untagged 32-bit integer on x64. There are debug mode
asserts in the code that catch tagged integers so we get test
failures if we get it wrong.
Review URL: http://codereview.chromium.org/3928002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5668 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
parent 5feede66
...@@ -101,9 +101,9 @@ class MacroAssembler: public Assembler { ...@@ -101,9 +101,9 @@ class MacroAssembler: public Assembler {
// dirty. |object| is the object being stored into, |value| is the // dirty. |object| is the object being stored into, |value| is the
// object being stored. If |offset| is zero, then the |scratch| // object being stored. If |offset| is zero, then the |scratch|
// register contains the array index into the elements array // register contains the array index into the elements array
// represented as a Smi. All registers are clobbered by the // represented as an untagged 32-bit integer. All registers are
// operation. RecordWrite filters out smis so it does not update the // clobbered by the operation. RecordWrite filters out smis so it
// write barrier if the value is a smi. // does not update the write barrier if the value is a smi.
void RecordWrite(Register object, void RecordWrite(Register object,
int offset, int offset,
Register value, Register value,
...@@ -122,7 +122,7 @@ class MacroAssembler: public Assembler { ...@@ -122,7 +122,7 @@ class MacroAssembler: public Assembler {
// The value is known to not be a smi. // The value is known to not be a smi.
// object is the object being stored into, value is the object being stored. // object is the object being stored into, value is the object being stored.
// If offset is zero, then the scratch register contains the array index into // If offset is zero, then the scratch register contains the array index into
// the elements array represented as a Smi. // the elements array represented as an untagged 32-bit integer.
// All registers are clobbered by the operation. // All registers are clobbered by the operation.
void RecordWriteNonSmi(Register object, void RecordWriteNonSmi(Register object,
int offset, int offset,
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment