Commit 30164dc0 authored by hablich's avatar hablich Committed by Commit bot

Revert of Use v8::kGCCallbackFlagCollectAllAvailableGarbage in...

Revert of Use v8::kGCCallbackFlagCollectAllAvailableGarbage in Heap::CollectAllAvailableGarbage (patchset #1 id:1 of https://codereview.chromium.org/1762313002/ )

Reason for revert:
Breaks roll https://codereview.chromium.org/1768073002/ : https://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/191035

Original issue's description:
> Use v8::kGCCallbackFlagCollectAllAvailableGarbage in Heap::CollectAllAvailableGarbage
>
> Now that the embedder side supports v8::kGCCallbackFlagCollectAllAvailableGarbage,
> this CL removes the old v8::kGCCallbackFlagForced from Heap::CollectAllAvailableGarbage.
>
> BUG=591463
> LOG=Y
>
> Committed: https://crrev.com/2436674c97f9e0bbc46a4bd75317e6470b4e720d
> Cr-Commit-Position: refs/heads/master@{#34517}

TBR=jochen@chromium.org,haraken@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=591463

Review URL: https://codereview.chromium.org/1771753002

Cr-Commit-Position: refs/heads/master@{#34520}
parent aa577080
......@@ -895,7 +895,7 @@ void Heap::CollectAllAvailableGarbage(const char* gc_reason) {
const int kMinNumberOfAttempts = 2;
for (int attempt = 0; attempt < kMaxNumberOfAttempts; attempt++) {
if (!CollectGarbage(MARK_COMPACTOR, gc_reason, NULL,
v8::kGCCallbackFlagCollectAllAvailableGarbage) &&
v8::kGCCallbackFlagForced) &&
attempt + 1 >= kMinNumberOfAttempts) {
break;
}
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment