[profiler] Minor CollectSourcePositionsForAllBytecodeArrays improvement

Skip over SFIs that already have source position available.

Bug: v8:7790
Change-Id: Iaea51fe1e4cec9e3291a258a1c60b2354afa8525
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3074239Reviewed-by: Jakob Gruber <jgruber@chromium.org>
Commit-Queue: Camillo Bruni <cbruni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#76112}

src/execution/isolate.cc

@@ -4816,12 +4816,10 @@ void Isolate::CollectSourcePositionsForAllBytecodeArrays() {
     HeapObjectIterator iterator(heap());
     for (HeapObject obj = iterator.Next(); !obj.is_null();
          obj = iterator.Next()) {
-      if (obj.IsSharedFunctionInfo()) {
-        SharedFunctionInfo sfi = SharedFunctionInfo::cast(obj);
-        if (sfi.HasBytecodeArray()) {
-          sfis.push_back(Handle<SharedFunctionInfo>(sfi, this));
-        }
-      }
+      if (!obj.IsSharedFunctionInfo()) continue;
+      SharedFunctionInfo sfi = SharedFunctionInfo::cast(obj);
+      if (!sfi.CanCollectSourcePosition(this)) continue;
+      sfis.push_back(Handle<SharedFunctionInfo>(sfi, this));
     }
   }
   for (auto sfi : sfis) {

src/objects/shared-function-info-inl.h

@@ -502,6 +502,11 @@ bool SharedFunctionInfo::has_simple_parameters() {
   return scope_info(kAcquireLoad).HasSimpleParameters();
 }
 
+bool SharedFunctionInfo::CanCollectSourcePosition(Isolate* isolate) {
+  return FLAG_enable_lazy_source_positions && HasBytecodeArray() &&
+         !GetBytecodeArray(isolate).HasSourcePositionTable();
+}
+
 bool SharedFunctionInfo::IsApiFunction() const {
   return function_data(kAcquireLoad).IsFunctionTemplateInfo();
 }

src/objects/shared-function-info.cc

@@ -670,8 +670,7 @@ void SharedFunctionInfo::SetPosition(int start_position, int end_position) {
 // static
 void SharedFunctionInfo::EnsureSourcePositionsAvailable(
     Isolate* isolate, Handle<SharedFunctionInfo> shared_info) {
-  if (FLAG_enable_lazy_source_positions && shared_info->HasBytecodeArray() &&
-      !shared_info->GetBytecodeArray(isolate).HasSourcePositionTable()) {
+  if (shared_info->CanCollectSourcePosition(isolate)) {
     Compiler::CollectSourcePositions(isolate, shared_info);
   }
 }

src/objects/shared-function-info.h

@@ -572,6 +572,7 @@ class SharedFunctionInfo
   void SetFunctionTokenPosition(int function_token_position,
                                 int start_position);
 
+  inline bool CanCollectSourcePosition(Isolate* isolate);
   static void EnsureSourcePositionsAvailable(
       Isolate* isolate, Handle<SharedFunctionInfo> shared_info);