Commit 2fed7a00 authored by kozyatinskiy's avatar kozyatinskiy Committed by Commit bot

[inspector] use BREAK_POSITION_ALIGNED for breakpoints

With inline breakpoints DevTools are ready for break position aligned breakpoints instead of statement aligned.

BUG=chromium:695236
R=dgozman@chromium.org,yangguo@chromium.org

Review-Url: https://codereview.chromium.org/2709263002
Cr-Commit-Position: refs/heads/master@{#43385}
parent 18e4c46d
...@@ -1377,7 +1377,7 @@ bool Debug::GetPossibleBreakpoints(Handle<Script> script, int start_position, ...@@ -1377,7 +1377,7 @@ bool Debug::GetPossibleBreakpoints(Handle<Script> script, int start_position,
CHECK(candidates[i]->HasDebugInfo()); CHECK(candidates[i]->HasDebugInfo());
Handle<DebugInfo> debug_info(candidates[i]->GetDebugInfo()); Handle<DebugInfo> debug_info(candidates[i]->GetDebugInfo());
FindBreakablePositions(debug_info, start_position, end_position, FindBreakablePositions(debug_info, start_position, end_position,
STATEMENT_ALIGNED, positions); BREAK_POSITION_ALIGNED, positions);
} }
return true; return true;
} }
......
...@@ -108,7 +108,7 @@ DebuggerScript.getGeneratorScopes = function(gen) ...@@ -108,7 +108,7 @@ DebuggerScript.getGeneratorScopes = function(gen)
*/ */
DebuggerScript.setBreakpoint = function(execState, info) DebuggerScript.setBreakpoint = function(execState, info)
{ {
var breakId = Debug.setScriptBreakPointById(info.sourceID, info.lineNumber, info.columnNumber, info.condition, undefined, Debug.BreakPositionAlignment.Statement); var breakId = Debug.setScriptBreakPointById(info.sourceID, info.lineNumber, info.columnNumber, info.condition, undefined, Debug.BreakPositionAlignment.BreakPosition);
var locations = Debug.findBreakPointActualLocations(breakId); var locations = Debug.findBreakPointActualLocations(breakId);
if (!locations.length) if (!locations.length)
return undefined; return undefined;
......
...@@ -71,7 +71,7 @@ class InspectorProtocolTestSuite(testsuite.TestSuite): ...@@ -71,7 +71,7 @@ class InspectorProtocolTestSuite(testsuite.TestSuite):
def ExpIterator(): def ExpIterator():
for line in expected_lines: for line in expected_lines:
if line.startswith("#") or not line.strip(): continue if not line.strip(): continue
yield line.strip() yield line.strip()
def ActIterator(lines): def ActIterator(lines):
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment