Commit 2fa76332 authored by Michael Achenbach's avatar Michael Achenbach Committed by Commit Bot

Revert "[debuger/deoptimizer] Remove GC invocation"

This reverts commit a7c78631.

Reason for revert:
https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/builds/21788

See: https://github.com/v8/v8/wiki/Blink-layout-tests

Original change's description:
> [debuger/deoptimizer] Remove GC invocation
> 
> This CL removes a GC invocation which might not be needed anymore.
> 
> Change-Id: I27c57936677ba2ec0bc32588c485a2c3b6ffed01
> Reviewed-on: https://chromium-review.googlesource.com/928241
> Reviewed-by: Yang Guo <yangguo@chromium.org>
> Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#51428}

TBR=yangguo@chromium.org,sigurds@chromium.org

Change-Id: Ifff9fdd060f7792208dfa01901836a1845b67bde
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/929661Reviewed-by: 's avatarMichael Achenbach <machenbach@chromium.org>
Commit-Queue: Michael Achenbach <machenbach@chromium.org>
Cr-Commit-Position: refs/heads/master@{#51450}
parent 3cdb96b0
...@@ -1141,6 +1141,10 @@ void Debug::DeoptimizeFunction(Handle<SharedFunctionInfo> shared) { ...@@ -1141,6 +1141,10 @@ void Debug::DeoptimizeFunction(Handle<SharedFunctionInfo> shared) {
// inlining. // inlining.
isolate_->AbortConcurrentOptimization(BlockingBehavior::kBlock); isolate_->AbortConcurrentOptimization(BlockingBehavior::kBlock);
// Make sure we abort incremental marking.
isolate_->heap()->CollectAllGarbage(Heap::kMakeHeapIterableMask,
GarbageCollectionReason::kDebugger);
bool found_something = false; bool found_something = false;
Code::OptimizedCodeIterator iterator(isolate_); Code::OptimizedCodeIterator iterator(isolate_);
while (Code* code = iterator.Next()) { while (Code* code = iterator.Next()) {
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment