Commit 2e5a90fd authored by mstarzinger's avatar mstarzinger Committed by Commit bot

[test] Run module tests in all variants.

By now the compilation pipeline is flexible enough to run module tests
against all variants, we should no longer choose unsupported compilers
for modules. It also fixes the predicate checking for functions being
"resumable" in the {AstNumberingVisitor} heuristic.

R=neis@chromium.org
BUG=v8:1569

Review-Url: https://codereview.chromium.org/2517143002
Cr-Commit-Position: refs/heads/master@{#41144}
parent 591a7ce0
......@@ -594,7 +594,7 @@ bool AstNumberingVisitor::Renumber(FunctionLiteral* node) {
DisableCrankshaft(kRestParameter);
}
if (IsGeneratorFunction(node->kind()) || IsAsyncFunction(node->kind())) {
if (IsResumableFunction(node->kind())) {
DisableCrankshaft(kGenerator);
}
......
......@@ -390,13 +390,6 @@
'test-cpu-profiler/FunctionApplySample': [PASS, ['system == windows', SKIP]],
}], # variant == turbofan or variant == ignition_turbofan
##############################################################################
['variant != ignition and variant != ignition_staging and variant != ignition_turbofan', {
# Ongoing implementation of modules.
# https://bugs.chromium.org/p/v8/issues/detail?id=1569
'test-modules/*': [SKIP],
}], # variant != ignition and variant != ignition_staging and variant != ignition_turbofan
##############################################################################
['variant == asm_wasm', {
'*': [SKIP],
......
......@@ -584,6 +584,10 @@
['variant == stress', {
'es6/array-iterator-turbo': [SKIP],
# Ongoing implementation of modules.
# https://bugs.chromium.org/p/v8/issues/detail?id=1569
'modules-debug-scopes1': [SKIP],
'ignition/regress-599001-verifyheap': [SKIP],
'unicode-test': [SKIP],
}], # variant == stress
......@@ -618,13 +622,6 @@
'unicodelctest-no-optimization': [SKIP],
}], # variant == ignition_turbofan
##############################################################################
['variant != ignition and variant != ignition_staging and variant != ignition_turbofan', {
# Ongoing implementation of modules.
# https://bugs.chromium.org/p/v8/issues/detail?id=1569
'modules-*': [SKIP],
}], # variant != ignition and variant != ignition_staging and variant != ignition_turbofan
##############################################################################
['gcov_coverage', {
# Tests taking too long.
......
......@@ -456,6 +456,23 @@
'language/expressions/object/method-definition/name-param-redecl': [FAIL],
'language/statements/async-function/early-errors-declaration-formals-body-duplicate': [FAIL],
# Module-related tests
# v8:5485
'language/module-code/comment-multi-line-html*': [FAIL],
'language/module-code/comment-single-line-html*': [FAIL],
# v8:5486
'language/module-code/instn-iee-star-cycle': [FAIL],
'language/module-code/instn-named-star-cycle': [FAIL],
'language/module-code/instn-star-star-cycle': [FAIL],
# v8:5487
'language/module-code/namespace/internals/get-own-property-str-found-uninit': [FAIL],
# v8:5401
'language/module-code/namespace/internals/set': [FAIL],
'language/module-code/namespace/internals/define-own-property': [FAIL],
######################## NEEDS INVESTIGATION ###########################
# These test failures are specific to the intl402 suite and need investigation
......@@ -605,33 +622,4 @@
'*': [SKIP],
}], # variant == wasm_traps
# Module-related tests
# https://bugs.chromium.org/p/v8/issues/detail?id=1569
['variant != ignition and variant != ignition_staging and variant != ignition_turbofan', {
'language/eval-code/direct/export': [SKIP],
'language/eval-code/direct/import': [SKIP],
'language/eval-code/indirect/export': [SKIP],
'language/eval-code/indirect/import': [SKIP],
'language/module-code/*': [SKIP],
}], # variant != ignition and variant != ignition_staging and variant != ignition_turbofan
['variant == ignition or variant == ignition_staging or variant == ignition_turbofan', {
# v8:5485
'language/module-code/comment-multi-line-html*': [FAIL],
'language/module-code/comment-single-line-html*': [FAIL],
# v8:5486
'language/module-code/instn-iee-star-cycle': [FAIL],
'language/module-code/instn-named-star-cycle': [FAIL],
'language/module-code/instn-star-star-cycle': [FAIL],
# v8:5487
'language/module-code/namespace/internals/get-own-property-str-found-uninit': [FAIL],
# v8:5401
'language/module-code/namespace/internals/set': [FAIL],
'language/module-code/namespace/internals/define-own-property': [FAIL],
}], # variant == ignition or variant == ignition_staging or variant == ignition_turbofan
]
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment