Commit 2d2ae175 authored by Dan Elphick's avatar Dan Elphick Committed by Commit Bot

[build] Quote messages for #error in v8-gn.h

While clang++ doesn't mind, g++ complains about apostrophes in #error
messages as they appear to be unterminated single-quoted literals. So
add surrounding double-quotes.

Bug: v8:11292
Change-Id: Ib263cb20c73650348599992186a0e7de11b1b306
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2639763
Auto-Submit: Dan Elphick <delphick@chromium.org>
Commit-Queue: Ross McIlroy <rmcilroy@chromium.org>
Reviewed-by: 's avatarRoss McIlroy <rmcilroy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#72192}
parent 83dc5168
......@@ -26,7 +26,7 @@ def generate_positive_definition(out, define):
#define {define} 1
#else
#if {define} != 1
#error {define} defined but not set to 1
#error "{define} defined but not set to 1"
#endif
#endif // {define}
'''.format(define=define))
......@@ -34,12 +34,12 @@ def generate_positive_definition(out, define):
def generate_negative_definition(out, define):
out.write('''
#ifdef {define}
#error {define} is defined but is disabled by V8's GN build arguments
#error "{define} is defined but is disabled by V8's GN build arguments"
#endif // {define}
'''.format(define=define))
def generate_header(out):
out.write('''// AUTOMATICALLY GENERATED. DO NOT EDIT.\n
out.write('''// AUTOMATICALLY GENERATED. DO NOT EDIT.
// The following definitions were used when V8 itself was built, but also appear
// in the externally-visible header files and so must be included by any
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment