Commit 2cc1f9a3 authored by Samuel Groß's avatar Samuel Groß Committed by V8 LUCI CQ

[sandbox] Enable the sandbox by default in gm.py

Since enabling the sandbox is now required for example for mkgrokdump,
add it to the default gn args. Also treat non-sandbox builds as
"non-shipping" in mkgrokdump.cc

Bug: v8:13281
Change-Id: I08042aa53057e25c556e166c059373e2fdb9d2c1
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3899317
Commit-Queue: Samuel Groß <saelo@chromium.org>
Reviewed-by: 's avatarJakob Kummerow <jkummerow@chromium.org>
Cr-Commit-Position: refs/heads/main@{#83231}
parent 80fb2815
...@@ -31,7 +31,7 @@ static const char* kHeader = ...@@ -31,7 +31,7 @@ static const char* kHeader =
"# yapf: disable\n\n"; "# yapf: disable\n\n";
// Debug builds emit debug code, affecting code object sizes. // Debug builds emit debug code, affecting code object sizes.
#ifndef DEBUG #if !defined(DEBUG) && defined(V8_ENABLE_SANDBOX)
static const char* kBuild = "shipping"; static const char* kBuild = "shipping";
#else #else
static const char* kBuild = "non-shipping"; static const char* kBuild = "non-shipping";
......
...@@ -169,6 +169,7 @@ v8_enable_disassembler = true ...@@ -169,6 +169,7 @@ v8_enable_disassembler = true
v8_enable_object_print = true v8_enable_object_print = true
v8_enable_verify_heap = true v8_enable_verify_heap = true
dcheck_always_on = false dcheck_always_on = false
v8_enable_sandbox = true
""".replace("{GOMA}", USE_GOMA) """.replace("{GOMA}", USE_GOMA)
DEBUG_ARGS_TEMPLATE = """\ DEBUG_ARGS_TEMPLATE = """\
...@@ -181,6 +182,7 @@ v8_enable_backtrace = true ...@@ -181,6 +182,7 @@ v8_enable_backtrace = true
v8_enable_fast_mksnapshot = true v8_enable_fast_mksnapshot = true
v8_enable_slow_dchecks = true v8_enable_slow_dchecks = true
v8_optimized_debug = false v8_optimized_debug = false
v8_enable_sandbox = true
""".replace("{GOMA}", USE_GOMA) """.replace("{GOMA}", USE_GOMA)
OPTDEBUG_ARGS_TEMPLATE = """\ OPTDEBUG_ARGS_TEMPLATE = """\
...@@ -193,6 +195,7 @@ v8_enable_backtrace = true ...@@ -193,6 +195,7 @@ v8_enable_backtrace = true
v8_enable_fast_mksnapshot = true v8_enable_fast_mksnapshot = true
v8_enable_verify_heap = true v8_enable_verify_heap = true
v8_optimized_debug = true v8_optimized_debug = true
v8_enable_sandbox = true
""".replace("{GOMA}", USE_GOMA) """.replace("{GOMA}", USE_GOMA)
ARGS_TEMPLATES = { ARGS_TEMPLATES = {
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment