Commit 2b86bb74 authored by Jakob Kummerow's avatar Jakob Kummerow Committed by Commit Bot

[promises] Fix missing write barrier in NewPromiseCapability

Change-Id: I0efbb837026908173739946353334ae7ebf62379
Reviewed-on: https://chromium-review.googlesource.com/461880Reviewed-by: 's avatarToon Verwaest <verwaest@chromium.org>
Commit-Queue: Jakob Kummerow <jkummerow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#44202}
parent f8973f1c
...@@ -27,9 +27,10 @@ Node* PromiseBuiltinsAssembler::AllocateJSPromise(Node* context) { ...@@ -27,9 +27,10 @@ Node* PromiseBuiltinsAssembler::AllocateJSPromise(Node* context) {
} }
void PromiseBuiltinsAssembler::PromiseInit(Node* promise) { void PromiseBuiltinsAssembler::PromiseInit(Node* promise) {
StoreObjectField(promise, JSPromise::kStatusOffset, StoreObjectFieldNoWriteBarrier(promise, JSPromise::kStatusOffset,
SmiConstant(v8::Promise::kPending)); SmiConstant(v8::Promise::kPending));
StoreObjectField(promise, JSPromise::kFlagsOffset, SmiConstant(0)); StoreObjectFieldNoWriteBarrier(promise, JSPromise::kFlagsOffset,
SmiConstant(0));
} }
Node* PromiseBuiltinsAssembler::AllocateAndInitJSPromise(Node* context) { Node* PromiseBuiltinsAssembler::AllocateAndInitJSPromise(Node* context) {
...@@ -123,8 +124,7 @@ Node* PromiseBuiltinsAssembler::NewPromiseCapability(Node* context, ...@@ -123,8 +124,7 @@ Node* PromiseBuiltinsAssembler::NewPromiseCapability(Node* context,
{ {
Node* promise = AllocateJSPromise(context); Node* promise = AllocateJSPromise(context);
PromiseInit(promise); PromiseInit(promise);
StoreObjectFieldNoWriteBarrier( StoreObjectField(capability, JSPromiseCapability::kPromiseOffset, promise);
capability, JSPromiseCapability::kPromiseOffset, promise);
Node* resolve = nullptr; Node* resolve = nullptr;
Node* reject = nullptr; Node* reject = nullptr;
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment