Commit 2a86d26f authored by balazs.kilvady's avatar balazs.kilvady Committed by Commit bot

MIPS: Improve '[es6] When comparing two symbols we may need to throw a TypeError'.

Improve d26f5d39

Original commit message:
When comparing a symbol to istself using <, <=, > or >= we need to
throw a TypeError. This is correctly handled in the runtime function
so if we are comparing a symbol fall back to use the runtime.

BUG=

Review URL: https://codereview.chromium.org/1124863004

Cr-Commit-Position: refs/heads/master@{#28240}
parent 38f7ccba
...@@ -294,7 +294,6 @@ static void EmitIdenticalObjectComparison(MacroAssembler* masm, ...@@ -294,7 +294,6 @@ static void EmitIdenticalObjectComparison(MacroAssembler* masm,
if (cc == less || cc == greater) { if (cc == less || cc == greater) {
__ GetObjectType(a0, t4, t4); __ GetObjectType(a0, t4, t4);
__ Branch(slow, greater, t4, Operand(FIRST_SPEC_OBJECT_TYPE)); __ Branch(slow, greater, t4, Operand(FIRST_SPEC_OBJECT_TYPE));
__ GetObjectType(a0, t4, t4);
__ Branch(slow, eq, t4, Operand(SYMBOL_TYPE)); __ Branch(slow, eq, t4, Operand(SYMBOL_TYPE));
} else { } else {
__ GetObjectType(a0, t4, t4); __ GetObjectType(a0, t4, t4);
......
...@@ -290,7 +290,6 @@ static void EmitIdenticalObjectComparison(MacroAssembler* masm, ...@@ -290,7 +290,6 @@ static void EmitIdenticalObjectComparison(MacroAssembler* masm,
if (cc == less || cc == greater) { if (cc == less || cc == greater) {
__ GetObjectType(a0, t0, t0); __ GetObjectType(a0, t0, t0);
__ Branch(slow, greater, t0, Operand(FIRST_SPEC_OBJECT_TYPE)); __ Branch(slow, greater, t0, Operand(FIRST_SPEC_OBJECT_TYPE));
__ GetObjectType(a0, t0, t0);
__ Branch(slow, eq, t0, Operand(SYMBOL_TYPE)); __ Branch(slow, eq, t0, Operand(SYMBOL_TYPE));
} else { } else {
__ GetObjectType(a0, t0, t0); __ GetObjectType(a0, t0, t0);
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment