Commit 2a1570ef authored by jochen's avatar jochen Committed by Commit bot

Temporarily undeprecate ForceSet

I first need to figure out what to do about window.document before we
can deprecate this: window.document is a regular accessor, however, once
the window navigated from about:blank, its value will never change.
Blink uses ForceSet to then replace the accessor with a data constant
which has way better performance than invoking the accessor all the
time.

Since the accessor, however, is installed as read only &
non-configurable, there is no spec compliant way to pull this off right
now

BUG=chromium:595601
R=verwaest@chromium.org
LOG=y

Review URL: https://codereview.chromium.org/1816033002

Cr-Commit-Position: refs/heads/master@{#34919}
parent 8872ec5e
...@@ -2683,10 +2683,10 @@ class V8_EXPORT Object : public Value { ...@@ -2683,10 +2683,10 @@ class V8_EXPORT Object : public Value {
V8_DEPRECATED("Use CreateDataProperty / DefineOwnProperty", V8_DEPRECATED("Use CreateDataProperty / DefineOwnProperty",
bool ForceSet(Local<Value> key, Local<Value> value, bool ForceSet(Local<Value> key, Local<Value> value,
PropertyAttribute attribs = None)); PropertyAttribute attribs = None));
V8_DEPRECATED("Use CreateDataProperty / DefineOwnProperty", V8_DEPRECATE_SOON("Use CreateDataProperty / DefineOwnProperty",
Maybe<bool> ForceSet(Local<Context> context, Local<Value> key, Maybe<bool> ForceSet(Local<Context> context,
Local<Value> value, Local<Value> key, Local<Value> value,
PropertyAttribute attribs = None)); PropertyAttribute attribs = None));
V8_DEPRECATE_SOON("Use maybe version", Local<Value> Get(Local<Value> key)); V8_DEPRECATE_SOON("Use maybe version", Local<Value> Get(Local<Value> key));
V8_WARN_UNUSED_RESULT MaybeLocal<Value> Get(Local<Context> context, V8_WARN_UNUSED_RESULT MaybeLocal<Value> Get(Local<Context> context,
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment