Commit 28ad7986 authored by Victor Gomes's avatar Victor Gomes Committed by V8 LUCI CQ

[baseline] Compile --always-sparkplug on the main thread

When --always-sparkplug, we compile on the main thread. This fixes the
CodeBuilder path when also running with --concurrent-sparkplug

Bug: v8:12054
Change-Id: Ifafcd68b635e99ca39c5eebc3e1ff839a2193eb4
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3233232
Commit-Queue: Victor Gomes <victorgomes@chromium.org>
Commit-Queue: Dominik Inführ <dinfuehr@chromium.org>
Auto-Submit: Victor Gomes <victorgomes@chromium.org>
Reviewed-by: 's avatarDominik Inführ <dinfuehr@chromium.org>
Cr-Commit-Position: refs/heads/main@{#77470}
parent a19359fa
......@@ -30,6 +30,11 @@ namespace internal {
ROOT_LIST(ROOT_ACCESSOR)
#undef ROOT_ACCESSOR
bool Factory::CodeBuilder::CompiledWithConcurrentBaseline() const {
return FLAG_concurrent_sparkplug && kind_ == CodeKind::BASELINE &&
!local_isolate_->is_main_thread();
}
Handle<String> Factory::InternalizeString(Handle<String> string) {
if (string->IsInternalizedString()) return string;
return isolate()->string_table()->LookupString(isolate(), string);
......
......@@ -934,9 +934,7 @@ class V8_EXPORT_PRIVATE Factory : public FactoryBase<Factory> {
return *this;
}
bool CompiledWithConcurrentBaseline() const {
return FLAG_concurrent_sparkplug && kind_ == CodeKind::BASELINE;
}
inline bool CompiledWithConcurrentBaseline() const;
private:
MaybeHandle<Code> BuildInternal(bool retry_allocation_or_fail);
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment