Commit 285e1e15 authored by bmeurer's avatar bmeurer Committed by Commit bot

[turbofan] Remove invalid typing rules.

Drop the typing rules for the machine operators and replace them
with UNREACHABLE. These typing rules were never correct and there's
also no need to have those rules at all.

Drive-by-fix: Remove the extremely annoying test-simplified-lowering.cc
file, which is not very useful, but consumes a large amount of time to
keep it compiling and passing. Instead we should introduce appropriate
tests for the SimplifiedLowering that also test something meaningful
w/o just cementing the implementation.

R=jarin@chromium.org
BUG=v8:5267

Review-Url: https://codereview.chromium.org/2292463002
Cr-Commit-Position: refs/heads/master@{#38970}
parent 98a79c94
This diff is collapsed.
...@@ -77,7 +77,6 @@ ...@@ -77,7 +77,6 @@
'compiler/test-run-stubs.cc', 'compiler/test-run-stubs.cc',
'compiler/test-run-variables.cc', 'compiler/test-run-variables.cc',
'compiler/test-run-wasm-machops.cc', 'compiler/test-run-wasm-machops.cc',
'compiler/test-simplified-lowering.cc',
'cctest.cc', 'cctest.cc',
'interpreter/interpreter-tester.cc', 'interpreter/interpreter-tester.cc',
'interpreter/source-position-matcher.cc', 'interpreter/source-position-matcher.cc',
......
...@@ -83,7 +83,6 @@ class ReducerTester : public HandleAndZoneScope { ...@@ -83,7 +83,6 @@ class ReducerTester : public HandleAndZoneScope {
common(main_zone()), common(main_zone()),
graph(main_zone()), graph(main_zone()),
javascript(main_zone()), javascript(main_zone()),
typer(isolate, &graph),
jsgraph(isolate, &graph, &common, &javascript, nullptr, &machine), jsgraph(isolate, &graph, &common, &javascript, nullptr, &machine),
maxuint32(Constant<int32_t>(kMaxUInt32)) { maxuint32(Constant<int32_t>(kMaxUInt32)) {
Node* s = graph.NewNode(common.Start(num_parameters)); Node* s = graph.NewNode(common.Start(num_parameters));
...@@ -97,7 +96,6 @@ class ReducerTester : public HandleAndZoneScope { ...@@ -97,7 +96,6 @@ class ReducerTester : public HandleAndZoneScope {
CommonOperatorBuilder common; CommonOperatorBuilder common;
Graph graph; Graph graph;
JSOperatorBuilder javascript; JSOperatorBuilder javascript;
Typer typer;
JSGraph jsgraph; JSGraph jsgraph;
Node* maxuint32; Node* maxuint32;
......
This diff is collapsed.
...@@ -15,7 +15,7 @@ namespace v8 { ...@@ -15,7 +15,7 @@ namespace v8 {
namespace internal { namespace internal {
namespace compiler { namespace compiler {
class BranchEliminationTest : public TypedGraphTest { class BranchEliminationTest : public GraphTest {
public: public:
BranchEliminationTest() BranchEliminationTest()
: machine_(zone(), MachineType::PointerRepresentation(), : machine_(zone(), MachineType::PointerRepresentation(),
......
...@@ -23,10 +23,10 @@ namespace v8 { ...@@ -23,10 +23,10 @@ namespace v8 {
namespace internal { namespace internal {
namespace compiler { namespace compiler {
class MachineOperatorReducerTest : public TypedGraphTest { class MachineOperatorReducerTest : public GraphTest {
public: public:
explicit MachineOperatorReducerTest(int num_parameters = 2) explicit MachineOperatorReducerTest(int num_parameters = 2)
: TypedGraphTest(num_parameters), machine_(zone()) {} : GraphTest(num_parameters), machine_(zone()) {}
protected: protected:
Reduction Reduce(Node* node) { Reduction Reduce(Node* node) {
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment