Commit 28279bd8 authored by Dan Elphick's avatar Dan Elphick Committed by Commit Bot

[cleanup] Remove unused Executability parameter

Removes unused parameter from CommitBlock and CommitMemory functions.

Change-Id: I4b79c1802060f1f70e06fd39532758fcdae2bead
Reviewed-on: https://chromium-review.googlesource.com/1039830Reviewed-by: 's avatarHannes Payer <hpayer@chromium.org>
Commit-Queue: Dan Elphick <delphick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#52936}
parent 519bd47f
...@@ -229,8 +229,7 @@ Address CodeRange::AllocateRawMemory(const size_t requested_size, ...@@ -229,8 +229,7 @@ Address CodeRange::AllocateRawMemory(const size_t requested_size,
bool CodeRange::CommitRawMemory(Address start, size_t length) { bool CodeRange::CommitRawMemory(Address start, size_t length) {
return isolate_->heap()->memory_allocator()->CommitMemory(start, length, return isolate_->heap()->memory_allocator()->CommitMemory(start, length);
EXECUTABLE);
} }
...@@ -462,8 +461,7 @@ int MemoryAllocator::Unmapper::NumberOfChunks() { ...@@ -462,8 +461,7 @@ int MemoryAllocator::Unmapper::NumberOfChunks() {
return static_cast<int>(result); return static_cast<int>(result);
} }
bool MemoryAllocator::CommitMemory(Address base, size_t size, bool MemoryAllocator::CommitMemory(Address base, size_t size) {
Executability executable) {
if (!SetPermissions(base, size, PageAllocator::kReadWrite)) { if (!SetPermissions(base, size, PageAllocator::kReadWrite)) {
return false; return false;
} }
...@@ -1180,7 +1178,7 @@ MemoryChunk* MemoryAllocator::AllocatePagePooled(SpaceType* owner) { ...@@ -1180,7 +1178,7 @@ MemoryChunk* MemoryAllocator::AllocatePagePooled(SpaceType* owner) {
const Address start = reinterpret_cast<Address>(chunk); const Address start = reinterpret_cast<Address>(chunk);
const Address area_start = start + MemoryChunk::kObjectStartOffset; const Address area_start = start + MemoryChunk::kObjectStartOffset;
const Address area_end = start + size; const Address area_end = start + size;
if (!CommitBlock(start, size, NOT_EXECUTABLE)) { if (!CommitBlock(start, size)) {
return nullptr; return nullptr;
} }
VirtualMemory reservation(start, size); VirtualMemory reservation(start, size);
...@@ -1190,9 +1188,8 @@ MemoryChunk* MemoryAllocator::AllocatePagePooled(SpaceType* owner) { ...@@ -1190,9 +1188,8 @@ MemoryChunk* MemoryAllocator::AllocatePagePooled(SpaceType* owner) {
return chunk; return chunk;
} }
bool MemoryAllocator::CommitBlock(Address start, size_t size, bool MemoryAllocator::CommitBlock(Address start, size_t size) {
Executability executable) { if (!CommitMemory(start, size)) return false;
if (!CommitMemory(start, size, executable)) return false;
if (Heap::ShouldZapGarbage()) { if (Heap::ShouldZapGarbage()) {
ZapBlock(start, size); ZapBlock(start, size);
......
...@@ -1359,7 +1359,7 @@ class V8_EXPORT_PRIVATE MemoryAllocator { ...@@ -1359,7 +1359,7 @@ class V8_EXPORT_PRIVATE MemoryAllocator {
size_t alignment, Executability executable, size_t alignment, Executability executable,
void* hint, VirtualMemory* controller); void* hint, VirtualMemory* controller);
bool CommitMemory(Address addr, size_t size, Executability executable); bool CommitMemory(Address addr, size_t size);
void FreeMemory(VirtualMemory* reservation, Executability executable); void FreeMemory(VirtualMemory* reservation, Executability executable);
void FreeMemory(Address addr, size_t size, Executability executable); void FreeMemory(Address addr, size_t size, Executability executable);
...@@ -1375,7 +1375,7 @@ class V8_EXPORT_PRIVATE MemoryAllocator { ...@@ -1375,7 +1375,7 @@ class V8_EXPORT_PRIVATE MemoryAllocator {
// the address is not kNullAddress, the size is greater than zero, and that // the address is not kNullAddress, the size is greater than zero, and that
// the block is contained in the initial chunk. Returns true if it succeeded // the block is contained in the initial chunk. Returns true if it succeeded
// and false otherwise. // and false otherwise.
bool CommitBlock(Address start, size_t size, Executability executable); bool CommitBlock(Address start, size_t size);
// Checks if an allocated MemoryChunk was intended to be used for executable // Checks if an allocated MemoryChunk was intended to be used for executable
// memory. // memory.
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment