Commit 270dccf6 authored by yangguo's avatar yangguo Committed by Commit bot

Correctly find shared function info for debugging when compiling eagerly.

R=ulan@chromium.org
BUG=v8:3717
LOG=N

Review URL: https://codereview.chromium.org/758523004

Cr-Commit-Position: refs/heads/master@{#25486}
parent 54b0109d
......@@ -2121,7 +2121,10 @@ Object* Debug::FindSharedFunctionInfoInScript(Handle<Script> script,
Heap* heap = isolate_->heap();
while (!done) {
{ // Extra scope for iterator.
HeapIterator iterator(heap);
// If lazy compilation is off, we won't have duplicate shared function
// infos that need to be filtered.
HeapIterator iterator(heap, FLAG_lazy ? HeapIterator::kNoFiltering
: HeapIterator::kFilterUnreachable);
for (HeapObject* obj = iterator.next();
obj != NULL; obj = iterator.next()) {
bool found_next_candidate = false;
......
// Copyright 2014 the V8 project authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
// Flags: --expose-debug-as debug --no-lazy
Debug = debug.Debug;
var exception = null;
var break_count = 0;
function f() {
function g(p) {
return 1;
}
g(1);
};
function listener(event, exec_state, event_data, data) {
try {
if (event == Debug.DebugEvent.Break) break_count++;
} catch (e) {
exception = e;
}
}
Debug.setListener(listener);
var bp = Debug.setBreakPoint(f, 2);
f();
Debug.clearBreakPoint(bp);
Debug.setListener(null);
assertEquals(1, break_count);
assertNull(exception);
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment