Commit 26ea3707 authored by bmeurer's avatar bmeurer Committed by Commit bot

[turbofan] Remove defensive programming for missing load/store eager bailout points.

We now have all the required eager bailout points in place, so we can
remove the defensive programming in JSNativeContextSpecialization.

R=jarin@chromium.org

Review-Url: https://codereview.chromium.org/1973773003
Cr-Commit-Position: refs/heads/master@{#36196}
parent 506999c3
...@@ -435,12 +435,7 @@ Reduction JSNativeContextSpecialization::ReduceNamedAccess( ...@@ -435,12 +435,7 @@ Reduction JSNativeContextSpecialization::ReduceNamedAccess(
if (nexus.IsUninitialized()) { if (nexus.IsUninitialized()) {
if ((flags() & kDeoptimizationEnabled) && if ((flags() & kDeoptimizationEnabled) &&
(flags() & kBailoutOnUninitialized)) { (flags() & kBailoutOnUninitialized)) {
// TODO(turbofan): Implement all eager bailout points correctly in return ReduceSoftDeoptimize(node);
// the graph builder.
Node* frame_state = NodeProperties::GetFrameStateInput(node, 1);
if (!OpParameter<FrameStateInfo>(frame_state).bailout_id().IsNone()) {
return ReduceSoftDeoptimize(node);
}
} }
return NoChange(); return NoChange();
} }
...@@ -452,12 +447,7 @@ Reduction JSNativeContextSpecialization::ReduceNamedAccess( ...@@ -452,12 +447,7 @@ Reduction JSNativeContextSpecialization::ReduceNamedAccess(
} else if (receiver_maps.length() == 0) { } else if (receiver_maps.length() == 0) {
if ((flags() & kDeoptimizationEnabled) && if ((flags() & kDeoptimizationEnabled) &&
(flags() & kBailoutOnUninitialized)) { (flags() & kBailoutOnUninitialized)) {
// TODO(turbofan): Implement all eager bailout points correctly in return ReduceSoftDeoptimize(node);
// the graph builder.
Node* frame_state = NodeProperties::GetFrameStateInput(node, 1);
if (!OpParameter<FrameStateInfo>(frame_state).bailout_id().IsNone()) {
return ReduceSoftDeoptimize(node);
}
} }
return NoChange(); return NoChange();
} }
...@@ -917,12 +907,7 @@ Reduction JSNativeContextSpecialization::ReduceKeyedAccess( ...@@ -917,12 +907,7 @@ Reduction JSNativeContextSpecialization::ReduceKeyedAccess(
if (nexus.IsUninitialized()) { if (nexus.IsUninitialized()) {
if ((flags() & kDeoptimizationEnabled) && if ((flags() & kDeoptimizationEnabled) &&
(flags() & kBailoutOnUninitialized)) { (flags() & kBailoutOnUninitialized)) {
// TODO(turbofan): Implement all eager bailout points correctly in return ReduceSoftDeoptimize(node);
// the graph builder.
Node* frame_state = NodeProperties::GetFrameStateInput(node, 1);
if (!OpParameter<FrameStateInfo>(frame_state).bailout_id().IsNone()) {
return ReduceSoftDeoptimize(node);
}
} }
return NoChange(); return NoChange();
} }
...@@ -934,12 +919,7 @@ Reduction JSNativeContextSpecialization::ReduceKeyedAccess( ...@@ -934,12 +919,7 @@ Reduction JSNativeContextSpecialization::ReduceKeyedAccess(
} else if (receiver_maps.length() == 0) { } else if (receiver_maps.length() == 0) {
if ((flags() & kDeoptimizationEnabled) && if ((flags() & kDeoptimizationEnabled) &&
(flags() & kBailoutOnUninitialized)) { (flags() & kBailoutOnUninitialized)) {
// TODO(turbofan): Implement all eager bailout points correctly in return ReduceSoftDeoptimize(node);
// the graph builder.
Node* frame_state = NodeProperties::GetFrameStateInput(node, 1);
if (!OpParameter<FrameStateInfo>(frame_state).bailout_id().IsNone()) {
return ReduceSoftDeoptimize(node);
}
} }
return NoChange(); return NoChange();
} }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment