Commit 232b97dd authored by titzer's avatar titzer Committed by Commit bot

[test] Clean up a couple TODOs.

R=bmeurer@chromium.org
BUG=

Review URL: https://codereview.chromium.org/1698063002

Cr-Commit-Position: refs/heads/master@{#33990}
parent 05218010
......@@ -34,7 +34,6 @@ namespace v8 {
namespace internal {
// Give alias names to registers for calling conventions.
// TODO(titzer): arm64 is a pain for aliasing; get rid of these macros
#define kReturnRegister0 x0
#define kReturnRegister1 x1
#define kReturnRegister2 x2
......
......@@ -738,7 +738,6 @@ class Instruction final {
return FlagsConditionField::decode(opcode());
}
// TODO(titzer): make call into a flags.
static Instruction* New(Zone* zone, InstructionCode opcode) {
return New(zone, opcode, 0, nullptr, 0, nullptr, 0, nullptr);
}
......
......@@ -163,17 +163,8 @@ class JSTypedLoweringTester : public HandleAndZoneScope {
}
Node* UseForEffect(Node* node) {
// TODO(titzer): use EffectPhi after fixing EffectCount
if (OperatorProperties::GetFrameStateInputCount(javascript.ToNumber()) >
0) {
CHECK_EQ(1, OperatorProperties::GetFrameStateInputCount(
javascript.ToNumber()));
return graph.NewNode(javascript.ToNumber(), node, context(),
EmptyFrameState(context()), node, control());
} else {
return graph.NewNode(javascript.ToNumber(), node, context(), node,
control());
}
Node* merge = graph.NewNode(common.Merge(1), start());
return graph.NewNode(common.EffectPhi(1), node, merge);
}
void CheckEffectInput(Node* effect, Node* use) {
......@@ -558,7 +549,6 @@ TEST(JSToString1) {
{ // ToString(number)
Node* r = R.ReduceUnop(op, Type::Number());
// TODO(titzer): could remove effects
CHECK_EQ(IrOpcode::kJSToString, r->opcode());
}
......@@ -896,9 +886,16 @@ TEST(StrictEqualityForRefEqualTypes) {
Node* p1 = R.Parameter(types[i]);
CheckEqualityReduction(&R, true, p0, p1, IrOpcode::kReferenceEqual);
}
// TODO(titzer): Equal(RefEqualTypes)
}
TEST(StrictEqualityForUnique) {
JSTypedLoweringTester R;
Node* p0 = R.Parameter(Type::Unique());
Node* p1 = R.Parameter(Type::Unique());
CheckEqualityReduction(&R, true, p0, p1, IrOpcode::kReferenceEqual);
CheckEqualityReduction(&R, true, p1, p0, IrOpcode::kReferenceEqual);
}
TEST(StringEquality) {
JSTypedLoweringTester R;
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment