Commit 21adacab authored by Simon Zünd's avatar Simon Zünd Committed by Commit Bot

Reserve two in-object properties slots for JSErrors

The most common use-case for creating errors is "new Error('message')".
The resulting JSError object has two properties. The message passed to
the constructor and an accessor for the stack.

This CL reserves two in-object property slots for these two, so no
PropertyArray has to be created.

Bug: v8:9116
Change-Id: I84467453446f333bf65425807707ee6581894e61
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1564195Reviewed-by: 's avatarBenedikt Meurer <bmeurer@chromium.org>
Reviewed-by: 's avatarJakob Gruber <jgruber@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#60791}
parent 8d30bd82
...@@ -1312,9 +1312,15 @@ static void InstallError(Isolate* isolate, Handle<JSObject> global, ...@@ -1312,9 +1312,15 @@ static void InstallError(Isolate* isolate, Handle<JSObject> global,
Handle<String> name, int context_index) { Handle<String> name, int context_index) {
Factory* factory = isolate->factory(); Factory* factory = isolate->factory();
Handle<JSFunction> error_fun = InstallFunction( // Most Error objects consist of a message and a stack trace.
isolate, global, name, JS_ERROR_TYPE, JSObject::kHeaderSize, 0, // Reserve two in-object properties for these.
factory->the_hole_value(), Builtins::kErrorConstructor); const int kInObjectPropertiesCount = 2;
const int kErrorObjectSize =
JSObject::kHeaderSize + kInObjectPropertiesCount * kTaggedSize;
Handle<JSFunction> error_fun =
InstallFunction(isolate, global, name, JS_ERROR_TYPE, kErrorObjectSize,
kInObjectPropertiesCount, factory->the_hole_value(),
Builtins::kErrorConstructor);
error_fun->shared()->DontAdaptArguments(); error_fun->shared()->DontAdaptArguments();
error_fun->shared()->set_length(1); error_fun->shared()->set_length(1);
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment