Commit 20eff45d authored by bmeurer's avatar bmeurer Committed by Commit bot

[turbofan] Remove the leftover LoadBuffer hacks.

R=jarin@chromium.org

Review URL: https://codereview.chromium.org/1887343002

Cr-Commit-Position: refs/heads/master@{#35509}
parent 39c39b54
...@@ -175,12 +175,9 @@ Reduction ChangeLowering::ChangeFloat64ToTagged(Node* value, Node* control) { ...@@ -175,12 +175,9 @@ Reduction ChangeLowering::ChangeFloat64ToTagged(Node* value, Node* control) {
Type* const value_type = NodeProperties::GetType(value); Type* const value_type = NodeProperties::GetType(value);
Node* const value32 = graph()->NewNode( Node* const value32 = graph()->NewNode(
machine()->TruncateFloat64ToInt32(TruncationMode::kRoundToZero), value); machine()->TruncateFloat64ToInt32(TruncationMode::kRoundToZero), value);
// TODO(bmeurer): This fast case must be disabled until we kill the asm.js if (value_type->Is(Type::Signed32())) {
// support in the generic JavaScript pipeline, because LoadBuffer is lying return ChangeInt32ToTagged(value32, control);
// about its result. }
// if (value_type->Is(Type::Signed32())) {
// return ChangeInt32ToTagged(value32, control);
// }
Node* check_same = graph()->NewNode( Node* check_same = graph()->NewNode(
machine()->Float64Equal(), value, machine()->Float64Equal(), value,
graph()->NewNode(machine()->ChangeInt32ToFloat64(), value32)); graph()->NewNode(machine()->ChangeInt32ToFloat64(), value32));
......
...@@ -767,12 +767,6 @@ struct SimplifiedLoweringPhase { ...@@ -767,12 +767,6 @@ struct SimplifiedLoweringPhase {
data->source_positions()); data->source_positions());
lowering.LowerAllNodes(); lowering.LowerAllNodes();
// TODO(bmeurer): See comment on SimplifiedLowering::abort_compilation_.
if (lowering.abort_compilation_) {
data->set_compilation_failed();
return;
}
JSGraphReducer graph_reducer(data->jsgraph(), temp_zone); JSGraphReducer graph_reducer(data->jsgraph(), temp_zone);
DeadCodeElimination dead_code_elimination(&graph_reducer, data->graph(), DeadCodeElimination dead_code_elimination(&graph_reducer, data->graph(),
data->common()); data->common());
...@@ -1283,9 +1277,6 @@ Handle<Code> Pipeline::GenerateCode() { ...@@ -1283,9 +1277,6 @@ Handle<Code> Pipeline::GenerateCode() {
// Kill the Typer and thereby uninstall the decorator (if any). // Kill the Typer and thereby uninstall the decorator (if any).
typer.Reset(nullptr); typer.Reset(nullptr);
// TODO(bmeurer): See comment on SimplifiedLowering::abort_compilation_.
if (data.compilation_failed()) return Handle<Code>::null();
return ScheduleAndGenerateCode( return ScheduleAndGenerateCode(
Linkage::ComputeIncoming(data.instruction_zone(), info())); Linkage::ComputeIncoming(data.instruction_zone(), info()));
} }
......
...@@ -38,11 +38,6 @@ class SimplifiedLowering final { ...@@ -38,11 +38,6 @@ class SimplifiedLowering final {
void DoStoreBuffer(Node* node); void DoStoreBuffer(Node* node);
void DoShift(Node* node, Operator const* op, Type* rhs_type); void DoShift(Node* node, Operator const* op, Type* rhs_type);
// TODO(bmeurer): This is a gigantic hack to support the gigantic LoadBuffer
// typing hack to support the gigantic "asm.js should be fast without proper
// verifier"-hack, ... Kill this! Soon! Really soon! I'm serious!
bool abort_compilation_ = false;
private: private:
JSGraph* const jsgraph_; JSGraph* const jsgraph_;
Zone* const zone_; Zone* const zone_;
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment